https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6304
Kevin A. McGrail <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4657|0 |1 is obsolete| | --- Comment #10 from Kevin A. McGrail <[email protected]> 2010-03-02 18:29:00 UTC --- Created an attachment (id=4690) --> (https://issues.apache.org/SpamAssassin/attachment.cgi?id=4690) patch for spamd adjustments to info level + small fix to Makefile.PL - Changed one info call to use %s instead of $pid by accident (In reply to comment #9) > +1 as per Mark's comments it's actually (In reply to comment #8) > > Needs 2 more votes to commit patch from comment 5 > > +1 > > Looks ok, with one nitpick: > > > info("prefork: adjust: %s idle children more than %s maximum idle children. > > Decreasing spamd children: $pid killed.", $num_idle, $self->{max_idle}, > > $pid); > > Please never mix the sprintf-style (format, with arguments) with classical > style (no arguments) of calls to info() and dbg(). As soon as extra arguments > are specified, the first one is interpreted as a sprintf format, and > interpolated > variables should generally not be allowed there (without a good reason). Ahh, I didn't mean to do that. That's a bug. I passed in the $pid to info but should have used %s. trivial revision in the patch rev2. -- Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.
