https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6340

--- Comment #7 from Mark Martinec <[email protected]> 2010-03-02 11:19:58 
UTC ---
> Just to be awkward a different patch. 
> Both previous patches miss a few edge cases (alias domains and mailing lists)

Thanks!

> by removing the die() mail to alias domains is still processed

Fine with me. We depend on actual users of vpopmail for input and testing.

> (Basically it's Mark's patch with some edge case thinking I badgered
> Sossi about on the previous bug brought in.) In theory it should handle
> mailing lists/mail routed to scripts also but I've not seen any yet.
> This is more in tune with how it was processed in 3.2.5.

Here is a diff between our (latest) versions:

--- spamd.raw.mark    2010-03-02 12:00:16.000000000 +0100
+++ spamd.raw.kevin   2010-03-02 12:04:40.000000000 +0100
@@ -2204,4 +2204,5 @@
     if (!defined($userdir)) {
-      die "failed to resolve vpopmail user/alias '$username' ".
-          "using vuserinfo/valias";
+      # A .qmail handler
+      undef $userdir;
+      last;
     }
@@ -2211,3 +2212,2 @@
     undef $userdir;
-    die "failed to resolve vpopmail user/alias '$username' in time
($vpoptimeout seconds)";
   } else {


I fail to see a point in: if (!defined($userdir)) { undef $userdir  } .
Also, what does a 'last' in that block do? We are already outside the loop.

-- 
Configure bugmail: 
https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

Reply via email to