https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6340

--- Comment #9 from Kevin Golding <[email protected]> 2010-03-02 13:11:08 UTC 
---
(In reply to comment #7)

> I fail to see a point in: if (!defined($userdir)) { undef $userdir  } .
> Also, what does a 'last' in that block do? We are already outside the loop.

Both those will largely come down to my stubborn determination to finish what I
started despite forgetting to switch off my phone, in my distraction I didn't
notice I was out of the loop.  I think in the 3.2.5 patch the check was still
done inside the loop so when I first thought I was still in there I didn't
double check.

As for the other part..  I was mainly looking at the die() part of the
statement which I wanted to kick out.  Given the disturbances here this morning
I must confess I didn't really think about the if() but logically I guess that
whole statement should be purged now we don't die() in there.

Basically just I assumed it was a trivial enough tweak I didn't need to worry
about my mind being elsewhere and I should have.

-- 
Configure bugmail: 
https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

Reply via email to