https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6605

             Bug #: 6605
           Summary: Suboptimal results when svn keywords aren't expanded
           Product: Spamassassin
           Version: SVN Trunk (Latest Devel Version)
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: trivial
          Priority: P2
         Component: spamassassin
        AssignedTo: [email protected]
        ReportedBy: [email protected]
    Classification: Unclassified


The Ubuntu daily builds stuff is not capable of expanding svn keywords, which
is quite clearly a bug in their software, but spamassassin could handle it
better.

(I expect to be the one to fix this.)

Symptoms:

The two instances of "updated" in this should be numbers:
X-Spam-Checker-Version: SpamAssassin 3.4.0-rupdated (updated) on
panic.chaosreigns.com

/etc/cron.daily/spamassassin:
Use of uninitialized value in concatenation (.) or string at /usr/bin/sa-update
line 23.


Example code lines as retrieved via svn, with svn keywords expanded:

$SUB_VERSION = (split(/\s+/,'$LastChangedDate: 2010-03-30 08:02:18 -0400 (Tue,
30 Mar 2010) $ updated by SVN'))[1];
       ('r' . qw{$LastChangedRevision: 929098 $ updated by SVN}[1]));

Same lines retrieved with Ubuntu build recipe, without svn keyword expansion:

$SUB_VERSION = (split(/\s+/,'$LastChangedDate$ updated by SVN'))[1];
       ('r' . qw{$LastChangedRevision$ updated by SVN}[1]));


In sa-update, the problem is $Id$:

my $VERSION = 'svn' . (split(/\s+/,
  '$Id$'))[2];


It looks like the keywords used are defined in these files:

trunk$ grep -rl svn:keywords .


For reference, the bug against the Ubuntu building system: 
https://bugs.launchpad.net/launchpad/+bug/780916

-- 
Configure bugmail: 
https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

Reply via email to