https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6605
Darxus <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #3 from Darxus <[email protected]> 2011-05-27 21:28:58 UTC --- (In reply to comment #2) > Without testing of this in the Ubuntu daily build AND outside of that system, > this seems dangerously close to changes sole for a downstream package > requirement. Yup. But it doesn't harm anything, it's well commented, and it increases the chances I'll continue to test daily builds on my mail server. > I need some help with a test protocol if you want me to consider voting for > this patch: > > a - Can you even test this without it going into trunk for launchpad? I could. I would need to create another svn repository, commit the change to it, set up importation of that new repo on launchpad, and create a new build recipe to build from it. Fortunately, the only thing it can break that can't be tested without going through all that is building Debian packages. Which I'm comfortable risking for the amount of time it takes to commit to trunk, tell launchpad to pull from trunk now, tell launchpad to rebuild the packages now, install, and test them. > b - How can I test that it doesn't break things outside of launchpad? Install in the normal manner without launchpad. I'm planning to do this in virtualbox later because installing from source makes me feel icky. If a little clarification on the patch helps, its function is pretty simple: There are three svn keywords involved. For each one, it checks to see if the keyword has been expanded by checking for it to contain a ":". If it's there, the behavior doesn't change. If it's not, it uses "unknown" instead of what it would use if expansion had happened. -- Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.
