> On 6/7/2011 7:22 PM, Adam Katz wrote:
> >> header EXTRA_MPART_TYPE         Content-Type =~ / type=/i
> 
> On 06/07/2011 08:00 PM, Matt Kettler wrote:
> > A lot of times rules start off with the writer thinking about the
> > whole line, and after they put it down as a rule, there may be
> > frivolous patterns... I've caught myself doing it dozens of times. I
> > suspect (without really knowing) that happened here.
> > 
> > Nice catch.
> > 
> > +1 on making the change for efficiency.
> > 
> > That said, I propose we should remove this rule entirely, or zero its
> > score.
> > 
> > The S/O of this rule is now 0.100 in ruleqa, and was 0.283 in the
> > 3.3.0 corpus for set0.  Clearly it is a lousy indicator of spam, but
> > has a force-assigned score of 1.0.
> 
> Its s/o is 0.086 on my data.  Nothing depends on it, so I've just
> cleared it out altogether (svn r1133500).

This broke Jenkins two days ago, please remove the remains of the rule:

$ perl -T -w ../spamassassin.raw -C log/test_rules_copy  --siteconfigpath 
log/localrules.tmp -p log/test_default.cf  -L --lint
Jun 10 14:30:08.727 [13978] warn: config: warning: description exists for 
non-existent rule EXTRA_MPART_TYPE

$ grep EXTRA_MPART_TYPE rules/*.cf
rules/30_text_de.cf:lang de describe EXTRA_MPART_TYPE Unnötige Parameter in 
"Content-Type"-Kopfzeile ("...type=")
rules/30_text_fr.cf:lang fr describe EXTRA_MPART_TYPE   En-tête 
"Content-type:...type=" surnuméraire
rules/30_text_nl.cf:lang nl describe EXTRA_MPART_TYPE                Header 
heeft een overbodige Content-type:...type= 
rules/30_text_pl.cf:lang pl describe EXTRA_MPART_TYPE   Nag³ówek zawiera 
nadmiarowy wpis Content-type:...type=
rules/50_scores.cf:score EXTRA_MPART_TYPE     1.0


  Mark

Reply via email to