On 13/01/2013 18:06, John Hardin wrote:
Agreed. Generally the caller looks for the "X-Spam-Status: Yes,
score=16.6 ..." header in the processed message to make the
deliver/discard decision. I think it's dangerously confusing to redefine
"threshold" in this manner.
> ...
> I haven't looked at how the various glues process the spamc output,
> if
> they look for ==1 rather than >0 what I suggest might break lots of
> stuff.

Whereas my patch wouldn't break any existing code. Why would it be "dangerously confusing" to make this change when the default behaviour is identical, and we could give a relatively simple and easy explanation as to what it does?

On 13/01/2013 17:02, Axb wrote:
> Normally this is achieved by the glue as with Amavis, MailScanner,
> using
> the API or Fuglu using spamd results
>
> IMO, spamc should remain simple and lightweight.

But those pieces of software are much more heavyweight than a spam filtering script, and parsing the output headers is unnecessary processing. This change keeps spamc very lightweight but adds a very useful tool for anyone invoking it from a shell script.

By the way, I added a bug for this.  It's at:
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6890

--
Best regards,
Jeremy Morton (Jez)

Reply via email to