On Sun, 13 Jan 2013, Jeremy Morton wrote:
On 13/01/2013 18:06, John Hardin wrote:
Agreed. Generally the caller looks for the "X-Spam-Status: Yes,
score=16.6 ..." header in the processed message to make the
deliver/discard decision. I think it's dangerously confusing to redefine
"threshold" in this manner.
...
I haven't looked at how the various glues process the spamc output, if
they look for ==1 rather than >0 what I suggest might break lots of
stuff.
Whereas my patch wouldn't break any existing code. Why would it be
"dangerously confusing" to make this change when the default behaviour is
identical, and we could give a relatively simple and easy explanation as to
what it does?
Because you're redefining what "threshold" means from what it is in the
configuration files. Perhaps "dangerous" was overstating it a bit, but it
will make it less obvious to figure out when someone asks "this message
says it was spam but it's still being delivered!"
On 13/01/2013 17:02, Axb wrote:
Normally this is achieved by the glue as with Amavis, MailScanner,
using the API or Fuglu using spamd results
IMO, spamc should remain simple and lightweight.
But those pieces of software are much more heavyweight than a spam filtering
script, and parsing the output headers is unnecessary processing.
...which is why I kinda agreed with you.
This change keeps spamc very lightweight but adds a very useful tool for
anyone invoking it from a shell script.
By the way, I added a bug for this. It's at:
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6890
Thanks.
--
John Hardin KA7OHZ http://www.impsec.org/~jhardin/
[email protected] FALaholic #11174 pgpk -a [email protected]
key: 0xB8732E79 -- 2D8C 34F4 6411 F507 136C AF76 D822 E6E6 B873 2E79
-----------------------------------------------------------------------
The social contract exists so that everyone doesn't have to squat
in the dust holding a spear to protect his woman and his meat all
day every day. It does not exist so that the government can take
your spear, your meat, and your woman because it knows better what
to do with them. -- Dagny @ Ace of Spades
-----------------------------------------------------------------------
4 days until Benjamin Franklin's 307th Birthday
