On 2/14/2014 1:30 AM, Noah Meyerhans wrote:
While testing the 3.4.0 release before uploading to Debian, I noticed
what appear to be some superfluous warnings from sa-compile emitted even
it is run with --quiet.
zoom: rule __LARGE_PERCENT_AFTER will loop on SpamAssassin older than 3.3.2
running under Perl 5.12 or older, Bug 6558
zoom: rule __FOR_SALE_PRC_1K will loop on SpamAssassin older than 3.3.2 running
under Perl 5.12 or older, Bug 6558
zoom: rule __FOR_SALE_NET will loop on SpamAssassin older than 3.3.2 running
under Perl 5.12 or older, Bug 6558
zoom: rule __PILL_PRICE_02 will loop on SpamAssassin older than 3.3.2 running
under Perl 5.12 or older, Bug 6558
zoom: rule __FOR_SALE_PRC_10K will loop on SpamAssassin older than 3.3.2
running under Perl 5.12 or older, Bug 6558
zoom: rule __PILL_PRICE_01 will loop on SpamAssassin older than 3.3.2 running
under Perl 5.12 or older, Bug 6558
zoom: rule __FOR_SALE_OBO will loop on SpamAssassin older than 3.3.2 running
under Perl 5.12 or older, Bug 6558
zoom: rule __FOR_SALE_PRC_100K will loop on SpamAssassin older than 3.3.2
running under Perl 5.12 or older, Bug 6558
zoom: rule __FOR_SALE_LTP will loop on SpamAssassin older than 3.3.2 running
under Perl 5.12 or older, Bug 6558
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6558 provides the
history of these messages.
What I wonder is if these are necessary at all, given that we're neither
running "SpamAssassin older than 3.3.2", by definition, or a perl <=
5.12 (this is 5.18). I'm thinking of wrapping these warnings in dbg()
calls in the debian version, so they're not entirely disabled but not
quite so noisy. Thoughts on this? It seems odd to unconditionally show
such warnings in an environment other than the one they're warning
about.
Makes sense. if you want to submit a patch for the dbg with an if
version 3.3.2 or greater or perl >= 5.12, don't debug, that would be
great and I'll apply it quickly.
