On Fri, 14 Feb 2014, Kevin A. McGrail wrote:
On 2/14/2014 1:30 AM, Noah Meyerhans wrote:
While testing the 3.4.0 release before uploading to Debian
What I wonder is if these are necessary at all, given that we're neither
running "SpamAssassin older than 3.3.2", by definition, or a perl <=
5.12 (this is 5.18). I'm thinking of wrapping these warnings in dbg()
calls in the debian version, so they're not entirely disabled but not
quite so noisy.
Makes sense. if you want to submit a patch for the dbg with an if version
3.3.2 or greater ... don't debug,
Wouldn't that be equivalent to "if (0) debug" ?
This warning is more for the rule developers so that they can put
"if (version >= 3.003002)" around the problematic rule. If there was some
way to suppress it except during a full make, that might be a better
solution than version checks. Would dbg() do that?
Unfortunately the warning probably won't reach the end users it needs to
reach, as the warning likely isn't in the code pre-3.3.2 (I haven't
looked) and even if we were to patch the branches there's little
likelihood of someone who is running a version that old taking a minor
update to the old version rather than updating all the way to the latest
release.
--
John Hardin KA7OHZ http://www.impsec.org/~jhardin/
[email protected] FALaholic #11174 pgpk -a [email protected]
key: 0xB8732E79 -- 2D8C 34F4 6411 F507 136C AF76 D822 E6E6 B873 2E79
-----------------------------------------------------------------------
Gun Control is nothing more than an attempt to return to feudalism,
where the peasants are helpless and must humbly petition their lord
and master to protect them from bandits and thieves (when they can
get around to it), and where the lords and masters can abuse the
peasants whenever they like without fear of effective resistance.
-----------------------------------------------------------------------
8 days until George Washington's 282nd Birthday
