https://issues.apache.org/SpamAssassin/show_bug.cgi?id=7068
--- Comment #2 from Kevin A. McGrail <[email protected]> --- Some comments: - the biggest issue is that regardless of existing code, please take the time to add POD documentation so that new features not only get added but used in the future. - I don't see why you are passing the rule name to the eval and I removed that - You don't need T_ for the rule. It's a test rule automatically until it's promoted. - I added a rule with a 5% and a 2% threshold to see how it goes body PP_TOO_MUCH_UNICODE05 eval:check_abundant_unicode_ratio(0.05) describe PP_TOO_MUCH_UNICODE05 Is text/plain but has many unicode escapes score PP_TOO_MUCH_UNICODE05 1.0 tflags PP_TOO_MUCH_UNICODE05 publish body PP_TOO_MUCH_UNICODE02 eval:check_abundant_unicode_ratio(0.02) describe PP_TOO_MUCH_UNICODE02 Is text/plain but has many unicode escapes score PP_TOO_MUCH_UNICODE02 0.5 tflags PP_TOO_MUCH_UNICODE02 publish If it passes test, I'll commit and you can report more back. -- You are receiving this mail because: You are the assignee for the bug.
