https://issues.apache.org/SpamAssassin/show_bug.cgi?id=7068
--- Comment #3 from Philip Prindeville <[email protected]> --- (In reply to Kevin A. McGrail from comment #2) > - the biggest issue is that regardless of existing code, please take the > time to add POD documentation so that new features not only get added but > used in the future. I can attach a documentation patch if you want. > - I don't see why you are passing the rule name to the eval and I removed > that Sorry, passing it where? In the test rules? Okay, then does that mean that the 2nd line of: sub check_abundant_unicode_ratio { my ($self, $pms, undef, undef, $ratio) = @_; requires 1 less 'undef' in the list? > - I added a rule with a 5% and a 2% threshold to see how it goes > > body PP_TOO_MUCH_UNICODE05 eval:check_abundant_unicode_ratio(0.05) > describe PP_TOO_MUCH_UNICODE05 Is text/plain but has many unicode > escapes > score PP_TOO_MUCH_UNICODE05 1.0 > tflags PP_TOO_MUCH_UNICODE05 publish > > body PP_TOO_MUCH_UNICODE02 > eval:check_abundant_unicode_ratio(0.02) > describe PP_TOO_MUCH_UNICODE02 Is text/plain but has many unicode > escapes > score PP_TOO_MUCH_UNICODE02 0.5 > tflags PP_TOO_MUCH_UNICODE02 publish > > If it passes test, I'll commit and you can report more back. Awesome! Thanks. -- You are receiving this mail because: You are the assignee for the bug.
