https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7143
Bug ID: 7143
Summary: Evaluate makemaker version using perl best practices
Product: Spamassassin
Version: SVN Trunk (Latest Devel Version)
Hardware: PC
OS: Windows 7
Status: NEW
Severity: normal
Priority: P2
Component: Building & Packaging
Assignee: [email protected]
Reporter: [email protected]
As per:
http://perldoc.perl.org/perlmodstyle.html#Version-numbering
Makefile.PL can be simplified with:
--- Makefile.PL.orig 2015-02-20 14:09:08.821327624 -0600
+++ Makefile.PL 2015-02-20 14:09:42.725326495 -0600
@@ -8,12 +8,9 @@
use ExtUtils::MakeMaker;
# Store the version for later use
-my $mm_version = $ExtUtils::MakeMaker::VERSION;
-
# avoid stupid 'Argument "6.30_01" isn't numeric in numeric ge (>=)' warnings;
# strip off the beta subversion noise that causes the trouble.
-$mm_version =~ s/_\S+$//; # "6.30_01" => "6.30"
-$mm_version += 0;
+my $mm_version = eval $ExtUtils::MakeMaker::VERSION;
if ($mm_version < 6.17) {
die "SpamAssassin Makefile.PL requires at least ExtUtils::MakeMaker v6.17";
--
You are receiving this mail because:
You are the assignee for the bug.
