https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7153
--- Comment #2 from Philip Prindeville <[email protected]> --- (In reply to Kevin A. McGrail from comment #1) > svn commit -m 'Bug 7153 for leak of URILocalBL.pm to stderr' > Sending lib/Mail/SpamAssassin/Plugin/URILocalBL.pm > Transmitting file data . > Committed revision 1665706 > > This is a follow-up on bug 7079. > > You are defining $gic_wanted and have but as best I can tell, never using > those variables. > > Did you mean to have && $gic_wanted >= $gic_have as well in the conditions? It turns out that if you don't need to test the C and Perl version, just the... oh, bugger. Just the C version. That's not what I did, is it? If the Perl code is defining Geo::IP::GEOIP_SILENCE then it's a valid version. But we still need to test for the underlying C code to support that flag. > I added that for now. Otherwise I would comment out the $gic_wanted/have > definition. > > Considering resolved unless you say otherwise Philip. The correct test should have been: if ($flags && $gic_wanted >= $gic_have) { and I'm an idiot. Can you please fix that? We could have done the earlier sequence: my $flags = 0; eval '$flags = Geo::IP::GEOIP_SILENCE' if ($gip_wanted >= $gip_have); instead, but it being defined is implied by having the correct version and vice versa. -- You are receiving this mail because: You are the assignee for the bug.
