https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7195

--- Comment #6 from Kevin A. McGrail <[email protected]> ---
(In reply to Mark Martinec from comment #5)
> > Closing as resolved->invalid since it is not a bug in SA though it is caused
> > by a documented change in 3.4.1.
> 
> Not true. If the 3.4.1 is supposed to retain compatibility by
> still offering the Mail::SpamAssassin::Util::RegistrarBoundaries
> module (despite being deprecated) and the MS::Util::uri_to_domain(),
> then it is a bug in SA of not 'requiring' this module yet using it
> in the MS::Util::uri_to_domain() function.
> 
> Can't have it both ways: it's either still supported yet deprecated,
> or it is no longer supported and breaks compatibility with
> third-party plugins.

It's a good point and I struggled with not wanting to make the change but since
it also changed to the $self model, the deprecation was better since authors
would have to change it either way.

Overall, you could argue Util should still have a use of the old module but
since it would be completed removed in 3.4.2, I am +1 to declare it as
unsupported.

It's unfortunate that we tried to have a stepping stone for authors and failed.
 The take away is hopefully more users can test future release candidates to
avoid these issues.

KAM

-- 
You are receiving this mail because:
You are the assignee for the bug.

Reply via email to