https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7195
Mark Martinec <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|INVALID |WONTFIX --- Comment #7 from Mark Martinec <[email protected]> --- > > Can't have it both ways: it's either still supported yet deprecated, > > or it is no longer supported and breaks compatibility with > > third-party plugins. > > It's a good point and I struggled with not wanting to make the change but > since it also changed to the $self model, the deprecation was better since > authors would have to change it either way. > > Overall, you could argue Util should still have a use of the old module but > since it would be completed removed in 3.4.2, I am +1 to declare it as > unsupported. > > It's unfortunate that we tried to have a stepping stone for authors and > failed. The take away is hopefully more users can test future release > candidates to avoid these issues. In retrospect it seems to me it would have been better to release the 3.4.1 under a label of 3.5.0 (bumping a minor version instead of the maintenance version number) considering this incompatibility, the introduction of a significant new plugin, and some other largish changes. The maintenance number should have been reserved for bug fixes, with minimal new features. But it's too late to cry now over spilled milk. As a minimum this ticket should be closed as a 'wont fix' instead of 'invalid', as the bug is definitely there. If there will ever be a 3.4.2 release, I see no harm in adding the missing 'use' in Util.pm. This could go only into the 3.4 branch, no need for the trunk, which will eventually lose the RegistrarBoundaries anyway. I also think the (hypothetical) 3.4.2 should not yet remove the RegistrarBoundaries module, being a maintenance release (third digit). I'm adding the missing 'use' into the 3.4 branch, hoping not to stir too much rage: 3.4: (not trunk) Sending lib/Mail/SpamAssassin/Util.pm Committed revision 1679656. -- You are receiving this mail because: You are the assignee for the bug.
