On 25 Feb 2019, at 14:56, Kevin A. McGrail wrote:
All, it's frustrating that commits are happening without proper make
tests. It delays things greatly when trying to do releases that they
aren't in a passing state. Please consider this.
Mea culpa. The change in r1849441 was to fix bug 7302, which caused
quietly broken rule distribution. I couldn't imagine that the test suite
would depend on build/mkrules building a known-bad ruleset without
aborting.
Of course, we still want to make sure that build/mkrules doesn't
knowingly emit a bad ruleset with nothing but a warning.
I'll test an alternative approach... If anyone has a brilliant idea on
this, speak up!
-------- Forwarded Message --------
Subject: [Bug 7692] New: mkrules regression tests do not pass after
commit r1849441
Date: Mon, 25 Feb 2019 07:52:48 +0000
From: [email protected]
To: [email protected]
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7692
Bug ID: 7692
Summary: mkrules regression tests do not pass after commit
r1849441
Product: Spamassassin
Version: unspecified
Hardware: PC
OS: OpenBSD
Status: NEW
Severity: normal
Priority: P2
Component: Regression Tests
Assignee: [email protected]
Reporter: [email protected]
Target Milestone: Undefined
After commit r1849441 t/mkrules.t fails with:
$ prove t/mkrules.t t/mkrules.t .. 23/97 # Failed test at t/mkrules.t
line 134.
cannot open log/log/mkrules_t/rules/70_sandbox.cf or
log/mkrules_t/rules/70_sandbox.cf at t/SATest.pm line 706.
# Failed test at t/mkrules.t line 136.
Not found: manif_found = 70_sandbox.cf: WARNING: not listed in
manifest
file at t/mkrules.t line 138.
# Failed test at t/SATest.pm line 783.
Not found: lint_failed = LINT FAILED at t/mkrules.t line 138.
# Failed test at t/SATest.pm line 783.
# Failed test at t/mkrules.t line 138.
t/mkrules.t .. 85/97 # Looks like you failed 5 tests of 97.
t/mkrules.t .. Dubious, test returned 5 (wstat 1280, 0x500)
Failed 5/97 subtests Test Summary Report
-------------------
t/mkrules.t (Wstat: 1280 Tests: 97 Failed: 5)
Failed tests: 23-24, 26-27, 30
Non-zero exit status: 5
Files=1, Tests=97, 6 wallclock secs ( 0.05 usr 0.01 sys + 4.42 cusr
1.62
csys = 6.10 CPU)
Result: FAIL
Reverting the commit is a workaround.
Not sure if the problem is in mkrules or in regression tests.
--
You are receiving this mail because:
You are the assignee for the bug.
