On Wed, Jun 12, 2019 at 04:30:35PM +0300, Henrik K wrote: > On Wed, Jun 12, 2019 at 08:44:01AM -0400, Kevin A. McGrail wrote: > > On 6/12/2019 4:52 AM, Henrik K wrote: > > > Anyone have any idea what rules release package should contain? > > > > > > freemail test doesnt work because Mail-SpamAssassin-4.0.0/rules does not > > > include any 20_freemail*cf files. As they are not in MANIFEST file. > > > > > > Should freemail work out of the box without sa-update run or not? What > > > about the million other .cf files, what's the criteria? > > > > > Do you mean like a release from a distro? As a project, we have a > > release file and a rules file so you can bootstrap without sa-update. I > > wouldn't expect the release to function without either sa-update or a > > bootstrapped rules install. > > Bit of a chicken and egg problem here. > > If t/freemail.t is included in release.tar.gz, make test won't work. But > all tests are supposed to be included, so someone can test the package? How > can you test the package if rules need to be separately downloaded, should > "make disttest" emulate downloading the rulespackage then? > > Suffering flu right now, so not in my fastest mode..
I guess this can be fixed in t/freemail.t by adding internal freemail_domains gmail.com clause..