https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8002
Bug ID: 8002
Summary: Make perlcritic stricter to CPAN testing standards
Product: Spamassassin
Version: SVN Trunk (Latest Devel Version)
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P2
Component: Regression Tests
Assignee: dev@spamassassin.apache.org
Reporter: sid...@sidney.com
Target Milestone: Undefined
The upload of 4.0.0-pre2 as a trial to CPAN is generating many errors on their
test machines because they use Perl::Critic with stricter policies than we use
in our perlcritic test. For example, they enable
Bangs::ProhibitBitwiseOperators warnings which trigger a test failure just for
using | or & properly.
CPAN's testing procedure is not something that we can change. What we can do is
to go through our code and comment every line that generates a perlcritic
warning after confirming that the usage is intended, for example,
..._flag | &AI_PASSIVE, ## no critic (Bangs::ProhibitBitwiseOperators)
This issue is for going through the perlcritic warnings that are found by
CPAN's testers and fixing any errors revealed or adding a ## no critic comment
It isn't being targeted for the 4.0 milestone because it may be too big a job
and does not fix any bugs or provide new functionality. If we do make enough
progress with it, it will be good to have so that CPAN test results are not
drowned out by the noise from perlcritic.
The first step will be to change the severity threshold in our perlcritic test
from 5 to 4, to match CPAN, and in the test disable all policies that reveals
in our code.
The next steps will be to go through the code dealing with one policy at a
time, such as Bangs::ProhibitBitwiseOperators, then remove the disabling of
that policy from our test.
--
You are receiving this mail because:
You are the assignee for the bug.
