https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8002
Sidney Markowitz <sid...@sidney.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|Undefined |4.0.0 Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #3 from Sidney Markowitz <sid...@sidney.com> --- To test this properly, install the following CPAN modules: Perl::Critic::Policy::Bangs::ProhibitBitwiseOperators Perl::Critic::Policy::Perlsecret Perl::Critic::Policy::Compatibility::ProhibitThreeArgumentOpen Perl::Critic::Policy::Lax::ProhibitStringyEval::ExceptForRequire Perl::Critic::Policy::ValuesAndExpressions::PreventSQLInjection Perl::Critic::Policy::ControlStructures::ProhibitReturnInDoBlock The only changes required were to exclude more warnings in the perlcritic test. As with the ones that were already excluded, we should someday go through code and check the warnings, adding ## no critic as we go. trunk % svn ci -m "Bug 8002 - Exclude more PerlCritic policies that are checked on CPAN test machines" Sending t/perlcritic.pl Transmitting file data .done Committing transaction... Committed revision 1901489. -- You are receiving this mail because: You are the assignee for the bug.