https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8087

--- Comment #8 from Sidney Markowitz <sid...@sidney.com> ---
I looked at the code and at https://metacpan.org/pod/Mail::DMARC::Result

The specification for Mail::DMARC::Result says

"disposition
When the DMARC result is not pass, disposition is the results of applying DMARC
policy to a message."

That doesn't say what $result->disposition will be set to when result is pass.

Looking at our code, it doesn't matter what $pms->{dmarc_policy} is set to when
result is 'passed' as long as it is not set to 'no policy available' or
undefined.

Should the patch be modified to set $pms->{dmarc_policy} to 'none' if
$result->result eq 'pass' since the spec doesn't say what $result->disposition
will be in that case? Alternatively, set $pms->{dmarc_policy} to 'none' if
$result->disposition is undefined? Either should work to handle the case that
is not defined in the spec.

Even with this I still think this will be trivial enough to commit for 4.0.0
without triggering an rc5.

-- 
You are receiving this mail because:
You are the assignee for the bug.

Reply via email to