I just follow the comment Wehnchen Fan (of course it is not merged yet, but I wanted to bring this to the attention of the dev list)
"We should definitely merge it to branch 2.4, but I won't block the release since it's not that critical and it's still in progress. After it's merged, feel free to vote -1 on the RC voting email to include this change, if necessary." So if the vote is not valid, we can ignore it. But this should have been in, before 2.4 was cut IMHO, anyway. Stavros On Mon, Sep 17, 2018 at 4:53 PM, Nicholas Chammas < nicholas.cham...@gmail.com> wrote: > I believe -1 votes are merited only for correctness bugs and regressions > since the previous release. > > Does SPARK-23200 count as either? > > 2018년 9월 17일 (월) 오전 9:40, Stavros Kontopoulos <stavros.kontopoulos@ > lightbend.com>님이 작성: > >> -1 >> >> I would like to see: https://github.com/apache/spark/pull/22392 in, as >> discussed here: https://issues.apache.org/jira/browse/SPARK-23200. It is >> important IMHO for streaming on K8s. >> I just started testing it btw. >> >> Also 2.12.7(https://contributors.scala-lang.org/t/2-12-7-release/2301, >> https://github.com/scala/scala/milestone/73 is coming out (will be >> staged this week), do we want to build the beta 2.12 build against it? >> >> Stavros >> >> On Mon, Sep 17, 2018 at 8:00 AM, Wenchen Fan <cloud0...@gmail.com> wrote: >> >>> I confirmed that https://repository.apache.org/content/ >>> repositories/orgapachespark-1285 is not accessible. I did it via >>> ./dev/create-release/do-release-docker.sh -d /my/work/dir -s publish , >>> not sure what's going wrong. I didn't see any error message during it. >>> >>> Any insights are appreciated! So that I can fix it in the next RC. >>> Thanks! >>> >>> On Mon, Sep 17, 2018 at 11:31 AM Sean Owen <sro...@apache.org> wrote: >>> >>>> I think one build is enough, but haven't thought it through. The >>>> Hadoop 2.6/2.7 builds are already nearly redundant. 2.12 is probably >>>> best advertised as a 'beta'. So maybe publish a no-hadoop build of it? >>>> Really, whatever's the easy thing to do. >>>> On Sun, Sep 16, 2018 at 10:28 PM Wenchen Fan <cloud0...@gmail.com> >>>> wrote: >>>> > >>>> > Ah I missed the Scala 2.12 build. Do you mean we should publish a >>>> Scala 2.12 build this time? Current for Scala 2.11 we have 3 builds: with >>>> hadoop 2.7, with hadoop 2.6, without hadoop. Shall we do the same thing for >>>> Scala 2.12? >>>> > >>>> > On Mon, Sep 17, 2018 at 11:14 AM Sean Owen <sro...@apache.org> wrote: >>>> >> >>>> >> A few preliminary notes: >>>> >> >>>> >> Wenchen for some weird reason when I hit your key in gpg --import, it >>>> >> asks for a passphrase. When I skip it, it's fine, gpg can still >>>> verify >>>> >> the signature. No issue there really. >>>> >> >>>> >> The staging repo gives a 404: >>>> >> https://repository.apache.org/content/repositories/ >>>> orgapachespark-1285/ >>>> >> 404 - Repository "orgapachespark-1285 (staging: open)" >>>> >> [id=orgapachespark-1285] exists but is not exposed. >>>> >> >>>> >> The (revamped) licenses are OK, though there are some minor glitches >>>> >> in the final release tarballs (my fault) : there's an extra >>>> directory, >>>> >> and the source release has both binary and source licenses. I'll fix >>>> >> that. Not strictly necessary to reject the release over those. >>>> >> >>>> >> Last, when I check the staging repo I'll get my answer, but, were you >>>> >> able to build 2.12 artifacts as well? >>>> >> >>>> >> On Sun, Sep 16, 2018 at 9:48 PM Wenchen Fan <cloud0...@gmail.com> >>>> wrote: >>>> >> > >>>> >> > Please vote on releasing the following candidate as Apache Spark >>>> version 2.4.0. >>>> >> > >>>> >> > The vote is open until September 20 PST and passes if a majority >>>> +1 PMC votes are cast, with >>>> >> > a minimum of 3 +1 votes. >>>> >> > >>>> >> > [ ] +1 Release this package as Apache Spark 2.4.0 >>>> >> > [ ] -1 Do not release this package because ... >>>> >> > >>>> >> > To learn more about Apache Spark, please see >>>> http://spark.apache.org/ >>>> >> > >>>> >> > The tag to be voted on is v2.4.0-rc1 (commit >>>> 1220ab8a0738b5f67dc522df5e3e77ffc83d207a): >>>> >> > https://github.com/apache/spark/tree/v2.4.0-rc1 >>>> >> > >>>> >> > The release files, including signatures, digests, etc. can be >>>> found at: >>>> >> > https://dist.apache.org/repos/dist/dev/spark/v2.4.0-rc1-bin/ >>>> >> > >>>> >> > Signatures used for Spark RCs can be found in this file: >>>> >> > https://dist.apache.org/repos/dist/dev/spark/KEYS >>>> >> > >>>> >> > The staging repository for this release can be found at: >>>> >> > https://repository.apache.org/content/repositories/ >>>> orgapachespark-1285/ >>>> >> > >>>> >> > The documentation corresponding to this release can be found at: >>>> >> > https://dist.apache.org/repos/dist/dev/spark/v2.4.0-rc1-docs/ >>>> >> > >>>> >> > The list of bug fixes going into 2.4.0 can be found at the >>>> following URL: >>>> >> > https://issues.apache.org/jira/projects/SPARK/versions/2.4.0 >>>> >> > >>>> >> > FAQ >>>> >> > >>>> >> > ========================= >>>> >> > How can I help test this release? >>>> >> > ========================= >>>> >> > >>>> >> > If you are a Spark user, you can help us test this release by >>>> taking >>>> >> > an existing Spark workload and running on this release candidate, >>>> then >>>> >> > reporting any regressions. >>>> >> > >>>> >> > If you're working in PySpark you can set up a virtual env and >>>> install >>>> >> > the current RC and see if anything important breaks, in the >>>> Java/Scala >>>> >> > you can add the staging repository to your projects resolvers and >>>> test >>>> >> > with the RC (make sure to clean up the artifact cache before/after >>>> so >>>> >> > you don't end up building with a out of date RC going forward). >>>> >> > >>>> >> > =========================================== >>>> >> > What should happen to JIRA tickets still targeting 2.4.0? >>>> >> > =========================================== >>>> >> > >>>> >> > The current list of open tickets targeted at 2.4.0 can be found at: >>>> >> > https://issues.apache.org/jira/projects/SPARK and search for >>>> "Target Version/s" = 2.4.0 >>>> >> > >>>> >> > Committers should look at those and triage. Extremely important bug >>>> >> > fixes, documentation, and API tweaks that impact compatibility >>>> should >>>> >> > be worked on immediately. Everything else please retarget to an >>>> >> > appropriate release. >>>> >> > >>>> >> > ================== >>>> >> > But my bug isn't fixed? >>>> >> > ================== >>>> >> > >>>> >> > In order to make timely releases, we will typically not hold the >>>> >> > release unless the bug in question is a regression from the >>>> previous >>>> >> > release. That being said, if there is something which is a >>>> regression >>>> >> > that has not been correctly targeted please ping me or a committer >>>> to >>>> >> > help target the issue. >>>> >>> >> >> >> -- Stavros Kontopoulos *Senior Software Engineer* *Lightbend, Inc.* *p: +30 6977967274 <%2B1%20650%20678%200020>* *e: stavros.kontopou...@lightbend.com* <dave.mar...@lightbend.com>
