More analysis at https://github.com/apache/spark/pull/23634 It's not a regression, though it does relate to correctness, although somewhat niche. TD, Jose et al, is this a Blocker? and is the fix probably reliable enough to commit now?
On Mon, Jan 28, 2019 at 10:59 AM Sandeep Katta <sandeep0102.opensou...@gmail.com> wrote: > > I feel this https://issues.apache.org/jira/browse/SPARK-26154 bug should be > fixed in this release as it is related to data correctness > > On Mon, 28 Jan 2019 at 17:55, Takeshi Yamamuro <linguin....@gmail.com> wrote: >> >> Hi, all >> >> I checked the two issues below had been resolved and there is no blocker for >> branch-2.3 now, so I'll start prepare RC2 tomorrow. >> https://issues.apache.org/jira/browse/SPARK-26682 >> https://issues.apache.org/jira/browse/SPARK-26709 >> >> If there are some blockers and critical issues in branch-2.3, please let me >> know. >> >> Best, >> Takeshi >> >> On Thu, Jan 24, 2019 at 10:06 AM Takeshi Yamamuro <linguin....@gmail.com> >> wrote: >>> >>> Thanks, all. >>> >>> I'll start a new vote as rc2 after the two issues above resolved. >>> >>> Best, >>> Takeshi >>> >>> >>> On Thu, Jan 24, 2019 at 7:59 AM Xiao Li <gatorsm...@gmail.com> wrote: >>>> >>>> -1 >>>> >>>> https://issues.apache.org/jira/browse/SPARK-26709 is another blocker >>>> ticket that returns incorrect results. >>>> >>>> >>>> Marcelo Vanzin <van...@cloudera.com.invalid> 于2019年1月23日周三 下午12:01写道: >>>>> >>>>> -1 too. >>>>> >>>>> I just upgraded https://issues.apache.org/jira/browse/SPARK-26682 to >>>>> blocker. It's a small fix and we should make it in 2.3.3. >>>>> >>>>> On Thu, Jan 17, 2019 at 6:49 PM Takeshi Yamamuro <linguin....@gmail.com> >>>>> wrote: >>>>> > >>>>> > Please vote on releasing the following candidate as Apache Spark >>>>> > version 2.3.3. >>>>> > >>>>> > The vote is open until January 20 8:00PM (PST) and passes if a majority >>>>> > +1 PMC votes are cast, with >>>>> > a minimum of 3 +1 votes. >>>>> > >>>>> > [ ] +1 Release this package as Apache Spark 2.3.3 >>>>> > [ ] -1 Do not release this package because ... >>>>> > >>>>> > To learn more about Apache Spark, please see http://spark.apache.org/ >>>>> > >>>>> > The tag to be voted on is v2.3.3-rc1 (commit >>>>> > b5ea9330e3072e99841270b10dc1d2248127064b): >>>>> > https://github.com/apache/spark/tree/v2.3.3-rc1 >>>>> > >>>>> > The release files, including signatures, digests, etc. can be found at: >>>>> > https://dist.apache.org/repos/dist/dev/spark/v2.3.3-rc1-bin/ >>>>> > >>>>> > Signatures used for Spark RCs can be found in this file: >>>>> > https://dist.apache.org/repos/dist/dev/spark/KEYS >>>>> > >>>>> > The staging repository for this release can be found at: >>>>> > https://repository.apache.org/content/repositories/orgapachespark-1297 >>>>> > >>>>> > The documentation corresponding to this release can be found at: >>>>> > https://dist.apache.org/repos/dist/dev/spark/v2.3.3-rc1-docs/ >>>>> > >>>>> > The list of bug fixes going into 2.3.3 can be found at the following >>>>> > URL: >>>>> > https://issues.apache.org/jira/projects/SPARK/versions/12343759 >>>>> > >>>>> > FAQ >>>>> > >>>>> > ========================= >>>>> > How can I help test this release? >>>>> > ========================= >>>>> > >>>>> > If you are a Spark user, you can help us test this release by taking >>>>> > an existing Spark workload and running on this release candidate, then >>>>> > reporting any regressions. >>>>> > >>>>> > If you're working in PySpark you can set up a virtual env and install >>>>> > the current RC and see if anything important breaks, in the Java/Scala >>>>> > you can add the staging repository to your projects resolvers and test >>>>> > with the RC (make sure to clean up the artifact cache before/after so >>>>> > you don't end up building with a out of date RC going forward). >>>>> > >>>>> > =========================================== >>>>> > What should happen to JIRA tickets still targeting 2.3.3? >>>>> > =========================================== >>>>> > >>>>> > The current list of open tickets targeted at 2.3.3 can be found at: >>>>> > https://issues.apache.org/jira/projects/SPARK and search for "Target >>>>> > Version/s" = 2.3.3 >>>>> > >>>>> > Committers should look at those and triage. Extremely important bug >>>>> > fixes, documentation, and API tweaks that impact compatibility should >>>>> > be worked on immediately. Everything else please retarget to an >>>>> > appropriate release. >>>>> > >>>>> > ================== >>>>> > But my bug isn't fixed? >>>>> > ================== >>>>> > >>>>> > In order to make timely releases, we will typically not hold the >>>>> > release unless the bug in question is a regression from the previous >>>>> > release. That being said, if there is something which is a regression >>>>> > that has not been correctly targeted please ping me or a committer to >>>>> > help target the issue. >>>>> > >>>>> > -- >>>>> > --- >>>>> > Takeshi Yamamuro >>>>> >>>>> >>>>> >>>>> -- >>>>> Marcelo >>>>> >>>>> --------------------------------------------------------------------- >>>>> To unsubscribe e-mail: dev-unsubscr...@spark.apache.org >>>>> >>> >>> >>> -- >>> --- >>> Takeshi Yamamuro >> >> >> >> -- >> --- >> Takeshi Yamamuro --------------------------------------------------------------------- To unsubscribe e-mail: dev-unsubscr...@spark.apache.org