Github user pwendell commented on a diff in the pull request:

    https://github.com/apache/incubator-spark/pull/570#discussion_r9974017
  
    --- Diff: project/SparkBuild.scala ---
    @@ -236,13 +236,15 @@ object SparkBuild extends Build {
         publishLocalBoth <<= Seq(publishLocal in MavenCompile, 
publishLocal).dependOn
       ) ++ net.virtualvoid.sbt.graph.Plugin.graphSettings ++ ScalaStyleSettings
     
    -  val slf4jVersion = "1.7.2"
    +  val slf4jVersion = "1.7.5"
     
       val excludeCglib = ExclusionRule(organization = 
"org.sonatype.sisu.inject")
       val excludeJackson = ExclusionRule(organization = "org.codehaus.jackson")
       val excludeNetty = ExclusionRule(organization = "org.jboss.netty")
       val excludeAsm = ExclusionRule(organization = "asm")
       val excludeSnappy = ExclusionRule(organization = "org.xerial.snappy")
    +  val excludeCommonsLogging = ExclusionRule(organization = 
"commons-logging")
    +  val excludeSLF4J = ExclusionRule(organization = "org.slf4j")
    --- End diff --
    
    It appears that a few other things include slf4j: (zookeeper, the coda hale 
metrics libs, avro, akka). Should we apply this rule to those as well? Or were 
you focused only on libraries which might return _newer_ versions?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. To do so, please top-post your response.
If your project does not have this feature enabled and wishes so, or if the
feature is enabled but not working, please contact infrastructure at
infrastruct...@apache.org or file a JIRA ticket with INFRA.
---

Reply via email to