Github user mateiz commented on a diff in the pull request: https://github.com/apache/incubator-spark/pull/539#discussion_r10019048 --- Diff: core/src/main/scala/org/apache/spark/api/java/JavaPairRDD.scala --- @@ -699,8 +699,14 @@ object JavaPairRDD { } implicit def toRDD[K, V](rdd: JavaPairRDD[K, V]): RDD[(K, V)] = rdd.rdd - - + private[spark] + implicit def toJFunction2[T1, T2, R](fun: JFunction2[T1, T2, R]) + : Function2[T1, T2, R] = (x: T1, x1: T2) => fun.call(x, x1) --- End diff -- This looks pretty weird; add a space between the different implicits, and maybe write them like this: ``` private[spark] implicit def toJFunction2[T1, T2, R](fun: JFunction2[T1, T2, R]): Function2[T1, T2, R] = { (x: T1, x1: T2) => fun.call(x, x1) } ``` Note that our line length limit is 100 characters, so this should fit.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---