Github user mateiz commented on a diff in the pull request:

    https://github.com/apache/incubator-spark/pull/539#discussion_r10019362
  
    --- Diff: project/SparkBuild.scala ---
    @@ -88,6 +88,11 @@ object SparkBuild extends Build {
       }
       lazy val hadoopClient = if (hadoopVersion.startsWith("0.20.") || 
hadoopVersion == "1.0.0") "hadoop-core" else "hadoop-client"
     
    +  lazy val javaVersion = System.getProperty("java.specification.version")
    +  lazy val isJava8Enabled = if (javaVersion == "1.8") true else false
    --- End diff --
    
    You can simplify this to `lazy val isJava8Enabled = (javaVersion >= "1.8")`
    
    Note that it's better to use `>=` because 1.9 will sometime come out.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to