Github user mateiz commented on the pull request:

    https://github.com/apache/incubator-spark/pull/539#issuecomment-35962439
  
    Hey Prashant, I did another pass through this and it looks quite good, but 
I have a few comments:
    
    * Is there a way to add the Java 8 test projects to the Maven build? I'm 
not 100% sure it's possible but please look into it.
    * Add doc comments above the Function classes. Note that the previous Scala 
classes for these had comments already (e.g. 
https://github.com/apache/incubator-spark/pull/539/files#diff-16).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to