----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4621/ -----------------------------------------------------------
(Updated 2012-04-03 06:47:20.080415) Review request for Sqoop and Jarek Cecho. Changes ------- Factor out code that constructs the boundary query into a separate function. Summary ------- Sqoop free-form query import does not work with Oracle, MySQL, and Hsqldb. https://issues.apache.org/jira/browse/SQOOP-468 The changes include: 1) Use alias 't1' instead of table name in the qualified names. 2) Add 3 unit tests for Hsqldb, MySQL, and Oracle. This addresses bug SQOOP-468. https://issues.apache.org/jira/browse/SQOOP-468 Diffs (updated) ----- /src/test/com/cloudera/sqoop/manager/OracleFreeFormQueryTest.java PRE-CREATION /src/test/com/cloudera/sqoop/manager/MySQLFreeFormQueryTest.java PRE-CREATION /src/test/com/cloudera/sqoop/TestFreeFormQueryImport.java PRE-CREATION /src/java/org/apache/sqoop/mapreduce/DataDrivenImportJob.java 1308555 Diff: https://reviews.apache.org/r/4621/diff Testing ------- 1) The new tests verify that import with a simple free-form query that includes join works with 3 different DBs. 2) ant test, ant test -Dthirdparty=true, and ant checkstyle Thanks, Cheolsoo
