> On 2012-04-03 19:34:16, Jarek Cecho wrote: > > Hi Cheolsoo, > > your changes looks good to me. > > > > Jarcec
Please attach your patch to the JIRA and I'll commit it. - Jarek ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4621/#review6661 ----------------------------------------------------------- On 2012-04-03 06:47:20, Cheolsoo Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4621/ > ----------------------------------------------------------- > > (Updated 2012-04-03 06:47:20) > > > Review request for Sqoop and Jarek Cecho. > > > Summary > ------- > > Sqoop free-form query import does not work with Oracle, MySQL, and Hsqldb. > > https://issues.apache.org/jira/browse/SQOOP-468 > > The changes include: > 1) Use alias 't1' instead of table name in the qualified names. > 2) Add 3 unit tests for Hsqldb, MySQL, and Oracle. > > > This addresses bug SQOOP-468. > https://issues.apache.org/jira/browse/SQOOP-468 > > > Diffs > ----- > > /src/test/com/cloudera/sqoop/manager/OracleFreeFormQueryTest.java > PRE-CREATION > /src/test/com/cloudera/sqoop/manager/MySQLFreeFormQueryTest.java > PRE-CREATION > /src/test/com/cloudera/sqoop/TestFreeFormQueryImport.java PRE-CREATION > /src/java/org/apache/sqoop/mapreduce/DataDrivenImportJob.java 1308555 > > Diff: https://reviews.apache.org/r/4621/diff > > > Testing > ------- > > 1) The new tests verify that import with a simple free-form query that > includes join works with 3 different DBs. > 2) ant test, ant test -Dthirdparty=true, and ant checkstyle > > > Thanks, > > Cheolsoo > >
