----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8063/#review13527 -----------------------------------------------------------
Ship it! Patch looks good to me, thank you Hari for your time. - Jarek Cecho On Nov. 16, 2012, 6:15 p.m., Hari Shreedharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8063/ > ----------------------------------------------------------- > > (Updated Nov. 16, 2012, 6:15 p.m.) > > > Review request for Sqoop. > > > Description > ------- > > Improved thread handling in SqoopOutputFormatLoadExecutor. Removed the > synchronized blocks and wait/notify. > > > This addresses bug SQOOP-690. > https://issues.apache.org/jira/browse/SQOOP-690 > > > Diffs > ----- > > > connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExportLoader.java > ff7384c > > execution/mapreduce/src/main/java/org/apache/sqoop/job/etl/HdfsSequenceImportLoader.java > 29a73b0 > > execution/mapreduce/src/main/java/org/apache/sqoop/job/etl/HdfsTextImportLoader.java > 711df0f > execution/mapreduce/src/main/java/org/apache/sqoop/job/io/Data.java 41fceb8 > > execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopOutputFormatLoadExecutor.java > 0d636ae > execution/mapreduce/src/test/java/org/apache/sqoop/job/TestMapReduce.java > 6dcf784 > spi/src/main/java/org/apache/sqoop/job/etl/Loader.java 3a708df > spi/src/main/java/org/apache/sqoop/job/io/DataReader.java 18e2fb7 > > Diff: https://reviews.apache.org/r/8063/diff/ > > > Testing > ------- > > Ran unit tests, and on a real cluster. > > > Thanks, > > Hari Shreedharan > >
