-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8203/
-----------------------------------------------------------

Review request for Sqoop.


Description
-------

I've added support for table hints into Microsoft SQL Connector.


This addresses bug SQOOP-724.
    https://issues.apache.org/jira/browse/SQOOP-724


Diffs
-----

  src/docs/user/connectors.txt d912840a519d408d2f6272a0761dda1fdbcc8859 
  src/java/org/apache/sqoop/manager/SQLServerManager.java 
51f867953c985094bb0325f4a834d6b30d815c3c 
  
src/java/org/apache/sqoop/mapreduce/sqlserver/SqlServerExportBatchOutputFormat.java
 PRE-CREATION 
  src/java/org/apache/sqoop/mapreduce/sqlserver/SqlServerInputFormat.java 
PRE-CREATION 
  src/java/org/apache/sqoop/mapreduce/sqlserver/SqlServerRecordReader.java 
PRE-CREATION 
  src/test/com/cloudera/sqoop/manager/SQLServerManagerExportManualTest.java 
ac7a934a634e5bd89b4107d607db7327fc83c6b2 
  src/test/com/cloudera/sqoop/manager/SQLServerManagerImportManualTest.java 
bf889d00ca3d7c1d35acc3a6ffc7f0a2551b8b53 

Diff: https://reviews.apache.org/r/8203/diff/


Testing
-------

I've added two unit tests that are more checking that new argument is working 
then it's actual usage. It's not trivial to test "hints" when SQL Server might 
decide not use them. I've also done real life testing on SQL Server Express.


Thanks,

Jarek Cecho

Reply via email to