> On Nov. 28, 2012, 8:25 p.m., Cheolsoo Park wrote: > > Hi Jarcec, > > > > Overall looks good. I have a few minor comments inline. I will commit it > > once you correct them, and all tests pass. > > > > Thanks!
Hi Cheolsoo, thank you very much for your review, I appreciate your time: > On Nov. 28, 2012, 8:25 p.m., Cheolsoo Park wrote: > > src/java/org/apache/sqoop/mapreduce/sqlserver/SqlServerExportBatchOutputFormat.java, > > line 51 > > <https://reviews.apache.org/r/8203/diff/1/?file=225448#file225448line51> > > > > Please delete ".". I can't it's required by our checkstyle rules. > On Nov. 28, 2012, 8:25 p.m., Cheolsoo Park wrote: > > src/java/org/apache/sqoop/mapreduce/sqlserver/SqlServerExportBatchOutputFormat.java, > > line 52 > > <https://reviews.apache.org/r/8203/diff/1/?file=225448#file225448line52> > > > > Put a space before "{". I can't as I would violate the checkstyle rules about 80 characters per single line. I consider the missing space as less evil than splitting this definition to two lines. - Jarek ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8203/#review13830 ----------------------------------------------------------- On Nov. 24, 2012, 5:07 a.m., Jarek Cecho wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8203/ > ----------------------------------------------------------- > > (Updated Nov. 24, 2012, 5:07 a.m.) > > > Review request for Sqoop. > > > Description > ------- > > I've added support for table hints into Microsoft SQL Connector. > > > This addresses bug SQOOP-724. > https://issues.apache.org/jira/browse/SQOOP-724 > > > Diffs > ----- > > src/docs/user/connectors.txt d912840a519d408d2f6272a0761dda1fdbcc8859 > src/java/org/apache/sqoop/manager/SQLServerManager.java > 51f867953c985094bb0325f4a834d6b30d815c3c > > src/java/org/apache/sqoop/mapreduce/sqlserver/SqlServerExportBatchOutputFormat.java > PRE-CREATION > src/java/org/apache/sqoop/mapreduce/sqlserver/SqlServerInputFormat.java > PRE-CREATION > src/java/org/apache/sqoop/mapreduce/sqlserver/SqlServerRecordReader.java > PRE-CREATION > src/test/com/cloudera/sqoop/manager/SQLServerManagerExportManualTest.java > ac7a934a634e5bd89b4107d607db7327fc83c6b2 > src/test/com/cloudera/sqoop/manager/SQLServerManagerImportManualTest.java > bf889d00ca3d7c1d35acc3a6ffc7f0a2551b8b53 > > Diff: https://reviews.apache.org/r/8203/diff/ > > > Testing > ------- > > I've added two unit tests that are more checking that new argument is working > then it's actual usage. It's not trivial to test "hints" when SQL Server > might decide not use them. I've also done real life testing on SQL Server > Express. > > > Thanks, > > Jarek Cecho > >
