> On May 28, 2013, 10:24 a.m., Jarek Cecho wrote: > > Hi Shruti, > > thank you very much for working on this, greatly appreciated. I do have > > couple of high level notes: > > > > 1) Would you mind update the documentation describing the new > > functionality? You can find the docs in src/docs/ directory. > > > > 2) Would you mind adding a tests that will exercise the added functionality? > > > > 3) Please run "ant checkstyle" to check out the coding style (for example > > we are not using tabulators but two spaces). > > > > Jarcec > > > > Shruti Joshi wrote: > Hi Jarek, > > I am working on updating docs in src/doc directory. I ran 'ant > checkstyle', but it hasn't reported any issues. > Will run again and resend the patch. > > Shruti > > > Jarek Cecho wrote: > Thank you Shruti, please let me know if you need any assistance, I'll be > waiting on your update on the review board.
Hi Jarek, I have resolved all the issues reported by "ant checkstyle" and also updated the documentation. Currently I am working on test-cases related to composite key support. Shruti - Shruti ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11041/#review21087 ----------------------------------------------------------- On May 27, 2013, 11:22 a.m., Shruti Joshi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11041/ > ----------------------------------------------------------- > > (Updated May 27, 2013, 11:22 a.m.) > > > Review request for Sqoop. > > > Description > ------- > > Sqoop does not support importing data into hbase when table contains > composite key. > > > This addresses bug https://issues.cloudera.org/browse/SQOOP-107. > > https://issues.apache.org/jira/browse/https://issues.cloudera.org/browse/SQOOP-107 > > > Diffs > ----- > > src/java/org/apache/sqoop/hbase/HBasePutProcessor.java 6aca97f > src/java/org/apache/sqoop/hbase/ToStringPutTransformer.java 13c765c > > Diff: https://reviews.apache.org/r/11041/diff/ > > > Testing > ------- > > ant test (default) was a success. > > > Thanks, > > Shruti Joshi > >
