> On May 28, 2013, 10:24 a.m., Jarek Cecho wrote: > > Hi Shruti, > > thank you very much for working on this, greatly appreciated. I do have > > couple of high level notes: > > > > 1) Would you mind update the documentation describing the new > > functionality? You can find the docs in src/docs/ directory. > > > > 2) Would you mind adding a tests that will exercise the added functionality? > > > > 3) Please run "ant checkstyle" to check out the coding style (for example > > we are not using tabulators but two spaces). > > > > Jarcec > > > > Shruti Joshi wrote: > Hi Jarek, > > I am working on updating docs in src/doc directory. I ran 'ant > checkstyle', but it hasn't reported any issues. > Will run again and resend the patch. > > Shruti > > > Jarek Cecho wrote: > Thank you Shruti, please let me know if you need any assistance, I'll be > waiting on your update on the review board. > > Shruti Joshi wrote: > Hi Jarek, > > I have resolved all the issues reported by "ant checkstyle" and also > updated the documentation. > Currently I am working on test-cases related to composite key support. > > Shruti
Hi Jarek, I am done with writing HBase test-cases for composite key support. I have resolved all the errors reported by 'ant checkstyle' and also modified the documents. I am not able to run the HBase related test-cases on my environment as it fails with the following exception - org.apache.zookeeper.ClientCnxn - Ignoring exception during shutdown input java.net.SocketException: Transport endpoint is not connected. at sun.nio.ch.SocketChannelImpl.shutdown(Native Method) [junit] 13/06/03 16:04:23 INFO master.ServerManager: Waiting on regionserver(s) to checkin [junit] 516801 [SyncThread:0] DEBUG org.apache.zookeeper.server.FinalRequestProcessor - Processing request:: sessionid:0x13f099253810005 type:ping cxid:0xfffffffffffffffe zxid:0xfffffffffffffffe txntype:unknown reqpath:n/a I am not able to figure out the actual cause for failure. Can you please help me with this? I am uploading the patch again with all the required changes along with the junit test-case for composite-key support in HBase. Shruti - Shruti ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11041/#review21087 ----------------------------------------------------------- On June 3, 2013, 1:04 p.m., Shruti Joshi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11041/ > ----------------------------------------------------------- > > (Updated June 3, 2013, 1:04 p.m.) > > > Review request for Sqoop. > > > Description > ------- > > Sqoop does not support importing data into hbase when table contains > composite key. > > > This addresses bug https://issues.cloudera.org/browse/SQOOP-107. > > https://issues.apache.org/jira/browse/https://issues.cloudera.org/browse/SQOOP-107 > > > Diffs > ----- > > src/docs/man/hbase-args.txt 7164e93 > src/docs/user/hbase-args.txt 36b930b > src/docs/user/hbase.txt 24c8df8 > src/java/org/apache/sqoop/hbase/HBasePutProcessor.java 6aca97f > src/java/org/apache/sqoop/hbase/ToStringPutTransformer.java 13c765c > src/test/com/cloudera/sqoop/hbase/HBaseImportTest.java d411f3d > > Diff: https://reviews.apache.org/r/11041/diff/ > > > Testing > ------- > > ant test (default) was a success. > > > Thanks, > > Shruti Joshi > >
