----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10987/#review21805 -----------------------------------------------------------
Ship it! Thanks for addressing the comments. I could successfully apply it. We can still make some of the enhancements I wrote in an earlier review, but those can definitely follow in a follow-on JIRA. - Venkat Ranganathan On June 12, 2013, 5:30 p.m., Shuaishuai Nie wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10987/ > ----------------------------------------------------------- > > (Updated June 12, 2013, 5:30 p.m.) > > > Review request for Sqoop. > > > Description > ------- > > Add the MS Sqoop connector tests that test integration scenarios with SQL > Server to the repo. > > > This addresses bug SQOOP-1035. > https://issues.apache.org/jira/browse/SQOOP-1035 > > > Diffs > ----- > > src/test/com/cloudera/sqoop/ThirdPartyTests.java 7e361d2 > src/test/com/cloudera/sqoop/hive/TestHiveImport.java 9c47bad > src/test/org/apache/sqoop/manager/sqlserver/MSSQLTestData.java PRE-CREATION > src/test/org/apache/sqoop/manager/sqlserver/MSSQLTestDataFileParser.java > PRE-CREATION > src/test/org/apache/sqoop/manager/sqlserver/MSSQLTestUtils.java > PRE-CREATION > src/test/org/apache/sqoop/manager/sqlserver/ManagerCompatExport.java > PRE-CREATION > > src/test/org/apache/sqoop/manager/sqlserver/SQLServerDatatypeExportDelimitedFileManualTest.java > PRE-CREATION > > src/test/org/apache/sqoop/manager/sqlserver/SQLServerDatatypeExportSequenceFileManualTest.java > PRE-CREATION > > src/test/org/apache/sqoop/manager/sqlserver/SQLServerDatatypeImportDelimitedFileManualTest.java > PRE-CREATION > > src/test/org/apache/sqoop/manager/sqlserver/SQLServerDatatypeImportSequenceFileManualTest.java > PRE-CREATION > > src/test/org/apache/sqoop/manager/sqlserver/SQLServerHiveImportManualTest.java > PRE-CREATION > src/test/org/apache/sqoop/manager/sqlserver/SQLServerManagerManualTest.java > PRE-CREATION > > src/test/org/apache/sqoop/manager/sqlserver/SQLServerMultiColsManualTest.java > PRE-CREATION > > src/test/org/apache/sqoop/manager/sqlserver/SQLServerMultiMapsManualTest.java > PRE-CREATION > > src/test/org/apache/sqoop/manager/sqlserver/SQLServerParseMethodsManualTest.java > PRE-CREATION > src/test/org/apache/sqoop/manager/sqlserver/SQLServerQueryManualTest.java > PRE-CREATION > src/test/org/apache/sqoop/manager/sqlserver/SQLServerSplitByManualTest.java > PRE-CREATION > src/test/org/apache/sqoop/manager/sqlserver/SQLServerWhereManualTest.java > PRE-CREATION > testdata/DatatypeTestData-export-lite.txt PRE-CREATION > testdata/DatatypeTestData-import-lite.txt PRE-CREATION > testdata/MSTest.properties PRE-CREATION > > Diff: https://reviews.apache.org/r/10987/diff/ > > > Testing > ------- > > All tests passing after applying the patch > > > Thanks, > > Shuaishuai Nie > >
