> On June 18, 2013, 10:09 p.m., Jarek Cecho wrote: > > Hi Shuaishuai, > > thank you very much for incorporating all the suggestions and notes, > > greatly appreciated. Please upload the latest patch to the JIRA and I'll > > commit this! > > > > Jarcec
Thanks Jarec. Attached the patch to JIRA. - Shuaishuai ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10987/#review22076 ----------------------------------------------------------- On June 18, 2013, 8:57 p.m., Shuaishuai Nie wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/10987/ > ----------------------------------------------------------- > > (Updated June 18, 2013, 8:57 p.m.) > > > Review request for Sqoop. > > > Description > ------- > > Add the MS Sqoop connector tests that test integration scenarios with SQL > Server to the repo. > > > This addresses bug SQOOP-1035. > https://issues.apache.org/jira/browse/SQOOP-1035 > > > Diffs > ----- > > build.xml ffc878e > src/test/com/cloudera/sqoop/ThirdPartyTests.java 7b1fa26 > src/test/com/cloudera/sqoop/hive/TestHiveImport.java 9c47bad > src/test/org/apache/sqoop/manager/sqlserver/MSSQLTestData.java PRE-CREATION > src/test/org/apache/sqoop/manager/sqlserver/MSSQLTestDataFileParser.java > PRE-CREATION > src/test/org/apache/sqoop/manager/sqlserver/MSSQLTestUtils.java > PRE-CREATION > src/test/org/apache/sqoop/manager/sqlserver/ManagerCompatExport.java > PRE-CREATION > > src/test/org/apache/sqoop/manager/sqlserver/SQLServerDatatypeExportDelimitedFileManualTest.java > PRE-CREATION > > src/test/org/apache/sqoop/manager/sqlserver/SQLServerDatatypeExportSequenceFileManualTest.java > PRE-CREATION > > src/test/org/apache/sqoop/manager/sqlserver/SQLServerDatatypeImportDelimitedFileManualTest.java > PRE-CREATION > > src/test/org/apache/sqoop/manager/sqlserver/SQLServerDatatypeImportSequenceFileManualTest.java > PRE-CREATION > > src/test/org/apache/sqoop/manager/sqlserver/SQLServerHiveImportManualTest.java > PRE-CREATION > src/test/org/apache/sqoop/manager/sqlserver/SQLServerManagerManualTest.java > PRE-CREATION > > src/test/org/apache/sqoop/manager/sqlserver/SQLServerMultiColsManualTest.java > PRE-CREATION > > src/test/org/apache/sqoop/manager/sqlserver/SQLServerMultiMapsManualTest.java > PRE-CREATION > > src/test/org/apache/sqoop/manager/sqlserver/SQLServerParseMethodsManualTest.java > PRE-CREATION > src/test/org/apache/sqoop/manager/sqlserver/SQLServerQueryManualTest.java > PRE-CREATION > src/test/org/apache/sqoop/manager/sqlserver/SQLServerSplitByManualTest.java > PRE-CREATION > src/test/org/apache/sqoop/manager/sqlserver/SQLServerWhereManualTest.java > PRE-CREATION > testdata/DatatypeTestData-export-lite.txt PRE-CREATION > testdata/DatatypeTestData-import-lite.txt PRE-CREATION > > Diff: https://reviews.apache.org/r/10987/diff/ > > > Testing > ------- > > All tests passing after applying the patch > > > Thanks, > > Shuaishuai Nie > >
