----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11952/#review22094 -----------------------------------------------------------
Hi Mengwei, thank you very much for working on this ticket, greatly appreciated! I would strongly advise to use separate REST end point for retrieving submission history as is documented in: https://github.com/apache/sqoop/blob/sqoop2/server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java#L30 The reason for that is that retrieving entire history might be quite expensive and long running task considering that Sqoop server can be hosting high number of historical submissions. Therefore it do make sense in my opinion to have separate very fast API for getting just the last submission that will be used in most cases and slower API for getting entire history when needed. I would suggest to create following new REST end points: * /v1/submission/history/:jid For all historical submissions for job with id :jid * /v1/submission/history/all For all historical submissions for all jobs Jarcec client/src/main/java/org/apache/sqoop/client/shell/ShowSubmissionFunction.java <https://reviews.apache.org/r/11952/#comment45483> I would suggest to make this client function similar to the others accepting either "--all" parameters for all submissions and "--jid" for submission from the particular job. common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java <https://reviews.apache.org/r/11952/#comment45484> Nit: We need to provide good test coverage for SubmissionBean class. - Jarek Cecho On June 18, 2013, 11:54 p.m., Mengwei Ding wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11952/ > ----------------------------------------------------------- > > (Updated June 18, 2013, 11:54 p.m.) > > > Review request for Sqoop, Jarek Cecho, Hari Shreedharan, and Abraham Elmahrek. > > > Description > ------- > > commit 6367bd9781040a77a355a2728c0e365338eb497e > Author: Mengwei Ding <mengwei.d...@cloudera.com> > Date: Tue Jun 18 15:43:25 2013 -0700 > > SQOOP-1088 Submission History API - Add both APIs and shell command > (`show submission`) > > :100644 100644 9c7b351... 0c5a596... M > client/src/main/java/org/apache/sqoop/client/SqoopClient.java > :100644 100644 056fcc8... 39f19df... M > client/src/main/java/org/apache/sqoop/client/core/Constants.java > :100644 100644 69edabb... 5042cb2... M > client/src/main/java/org/apache/sqoop/client/request/SubmissionRequest.java > :100644 100644 e24a7e8... 4245717... M > client/src/main/java/org/apache/sqoop/client/shell/ShowCommand.java > :000000 100644 0000000... 02b13bf... A > client/src/main/java/org/apache/sqoop/client/shell/ShowSubmissionFunction.java > :100644 100644 b159757... 439196c... M > client/src/main/resources/client-resource.properties > :100644 100644 1ef72eb... 91f2007... M > common/src/main/java/org/apache/sqoop/json/SubmissionBean.java > :100644 100644 6ee9aa1... ba9e94c... M > common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java > :100644 100644 d42e34a... 6071b0e... M > core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java > :100644 100644 3d29ab5... 0eaa539... M > core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java > :100644 100644 21dd759... d321079... M > core/src/main/java/org/apache/sqoop/repository/Repository.java > :100644 100644 073d547... 9ebb510... M > docs/src/site/sphinx/CommandLineClient.rst > :100644 100644 327896c... f91cd13... M > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepoError.java > :100644 100644 45a0da4... a8fe905... M > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java > :100644 100644 c8ce3aa... de9303f... M > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java > :100644 100644 de9a24b... 489ea37... M > server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java > > > This addresses bug SQOOP-1088. > https://issues.apache.org/jira/browse/SQOOP-1088 > > > Diffs > ----- > > client/src/main/java/org/apache/sqoop/client/SqoopClient.java 9c7b351 > client/src/main/java/org/apache/sqoop/client/core/Constants.java 056fcc8 > client/src/main/java/org/apache/sqoop/client/request/SubmissionRequest.java > 69edabb > client/src/main/java/org/apache/sqoop/client/shell/ShowCommand.java e24a7e8 > > client/src/main/java/org/apache/sqoop/client/shell/ShowSubmissionFunction.java > PRE-CREATION > client/src/main/resources/client-resource.properties b159757 > common/src/main/java/org/apache/sqoop/json/SubmissionBean.java 1ef72eb > common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java 6ee9aa1 > core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java d42e34a > core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java > 3d29ab5 > core/src/main/java/org/apache/sqoop/repository/Repository.java 21dd759 > docs/src/site/sphinx/CommandLineClient.rst 073d547 > > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepoError.java > 327896c > > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java > 45a0da4 > > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java > c8ce3aa > server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java > de9a24b > > Diff: https://reviews.apache.org/r/11952/diff/ > > > Testing > ------- > > Have done several tiny scale tests on my standalone virtual machine cluster. > > > Thanks, > > Mengwei Ding > >
