-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11952/#review22295
-----------------------------------------------------------

Ship it!


Ship It!

- Jarek Cecho


On June 21, 2013, 11:06 p.m., Mengwei Ding wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11952/
> -----------------------------------------------------------
> 
> (Updated June 21, 2013, 11:06 p.m.)
> 
> 
> Review request for Sqoop, Jarek Cecho, Hari Shreedharan, and Abraham Elmahrek.
> 
> 
> Description
> -------
> 
> commit 7e11dd64165daae5297c843055041edb2803f5da
> Author: Mengwei Ding <mengwei.d...@cloudera.com>
> Date:   Tue Jun 18 15:43:25 2013 -0700
> 
>     SQOOP-1088 Submission History API - Add both APIs and shell command 
> (`show submission`)
> 
> :100644 100644 9c7b351... 4ca71a4... M        
> client/src/main/java/org/apache/sqoop/client/SqoopClient.java
> :100644 100644 056fcc8... 06f8162... M        
> client/src/main/java/org/apache/sqoop/client/core/Constants.java
> :100644 100644 32d4ae1... f102c8f... M        
> client/src/main/java/org/apache/sqoop/client/request/SqoopRequests.java
> :100644 100644 69edabb... bafb30f... M        
> client/src/main/java/org/apache/sqoop/client/request/SubmissionRequest.java
> :100644 100644 e24a7e8... 4245717... M        
> client/src/main/java/org/apache/sqoop/client/shell/ShowCommand.java
> :000000 100644 0000000... 666eb7a... A        
> client/src/main/java/org/apache/sqoop/client/shell/ShowSubmissionFunction.java
> :100644 100644 1a6d896... 29144d1... M        
> client/src/main/java/org/apache/sqoop/client/shell/SubmissionStatusFunction.java
> :100644 100644 530ac92... 360a931... M        
> client/src/main/java/org/apache/sqoop/client/utils/SubmissionDisplayer.java
> :100644 100644 b159757... 8a570a1... M        
> client/src/main/resources/client-resource.properties
> :100644 100644 1ef72eb... 91f2007... M        
> common/src/main/java/org/apache/sqoop/json/SubmissionBean.java
> :100644 100644 6ee9aa1... 19a5bba... M        
> common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java
> :100644 100644 d42e34a... 135c2d2... M        
> core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java
> :100644 100644 3d29ab5... 538def5... M        
> core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java
> :100644 100644 21dd759... 666bfc1... M        
> core/src/main/java/org/apache/sqoop/repository/Repository.java
> :100644 100644 073d547... a14898f... M        
> docs/src/site/sphinx/CommandLineClient.rst
> :100644 100644 327896c... 4455f48... M        
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepoError.java
> :100644 100644 45a0da4... 0ea7bac... M        
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java
> :100644 100644 c8ce3aa... 7a9ce50... M        
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java
> :100644 100644 1c40fc1... 1f7a208... M        
> server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java
> 
> 
> This addresses bug SQOOP-1088.
>     https://issues.apache.org/jira/browse/SQOOP-1088
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/sqoop/client/SqoopClient.java 9c7b351 
>   client/src/main/java/org/apache/sqoop/client/core/Constants.java 056fcc8 
>   client/src/main/java/org/apache/sqoop/client/request/SqoopRequests.java 
> 32d4ae1 
>   client/src/main/java/org/apache/sqoop/client/request/SubmissionRequest.java 
> 69edabb 
>   client/src/main/java/org/apache/sqoop/client/shell/ShowCommand.java e24a7e8 
>   
> client/src/main/java/org/apache/sqoop/client/shell/ShowSubmissionFunction.java
>  PRE-CREATION 
>   
> client/src/main/java/org/apache/sqoop/client/shell/SubmissionStatusFunction.java
>  1a6d896 
>   client/src/main/java/org/apache/sqoop/client/utils/SubmissionDisplayer.java 
> 530ac92 
>   client/src/main/resources/client-resource.properties b159757 
>   common/src/main/java/org/apache/sqoop/json/SubmissionBean.java 1ef72eb 
>   common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java 6ee9aa1 
>   core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java d42e34a 
>   core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java 
> 3d29ab5 
>   core/src/main/java/org/apache/sqoop/repository/Repository.java 21dd759 
>   docs/src/site/sphinx/CommandLineClient.rst 073d547 
>   
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepoError.java
>  327896c 
>   
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java
>  45a0da4 
>   
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java
>  c8ce3aa 
>   server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java 
> 1c40fc1 
> 
> Diff: https://reviews.apache.org/r/11952/diff/
> 
> 
> Testing
> -------
> 
> Have done several tiny scale tests on my standalone virtual machine cluster.
> 
> 
> Thanks,
> 
> Mengwei Ding
> 
>

Reply via email to