-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12713/
-----------------------------------------------------------
(Updated Aug. 2, 2013, 9:36 p.m.)
Review request for Sqoop, Abraham Elmahrek, Hari Shreedharan, and Jarek Cecho.
Changes
-------
made changes based on review comments.
Bugs: SQOOP-1142
https://issues.apache.org/jira/browse/SQOOP-1142
Repository: sqoop-sqoop2
Description (updated)
-------
commit b524404b665b296462365e6823f24347f40f1462
Author: Mengwei Ding <[email protected]>
Date: Wed Jul 17 10:48:05 2013 -0700
SQOOP-1142 Sqoop2: Provide creater and last edited by to metadata structures
:100644 100644 999790d... beb08d5... M
client/src/main/java/org/apache/sqoop/client/core/Constants.java
:100644 100644 94f92b3... b3cdbcb... M
client/src/main/java/org/apache/sqoop/client/shell/ShowConnectionFunction.java
:100644 100644 97a240b... 8e6d77d... M
client/src/main/java/org/apache/sqoop/client/shell/ShowJobFunction.java
:100644 100644 cbc956d... 10b3130... M
client/src/main/java/org/apache/sqoop/client/utils/SubmissionDisplayer.java
:100644 100644 1a8f963... 91a4afe... M
client/src/main/resources/client-resource.properties
:100644 100644 a014ddd... 688bb64... M
common/src/main/java/org/apache/sqoop/json/ConnectionBean.java
:100644 100644 4685797... 1555bd5... M
common/src/main/java/org/apache/sqoop/json/JobBean.java
:100644 100644 79490f8... 61d6576... M
common/src/main/java/org/apache/sqoop/json/SubmissionBean.java
:100644 100644 3daf8d2... 9558941... M
common/src/main/java/org/apache/sqoop/json/util/FormSerialization.java
:100644 100644 5524983... f693d46... M
common/src/main/java/org/apache/sqoop/model/MAccountableEntity.java
:100644 100644 2f2b974... 19f81a8... M
common/src/test/java/org/apache/sqoop/json/TestConnectionBean.java
:100644 100644 3b56171... d87655e... M
common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java
:100644 100644 bf103e4... f3d4166... M
common/src/test/java/org/apache/sqoop/model/TestMAccountableEntity.java
:100644 100644 d0a087d... 733b201... M
core/src/main/java/org/apache/sqoop/framework/JobManager.java
:000000 100644 0000000... 15beed0... A
core/src/main/java/org/apache/sqoop/request/HttpEventContext.java
:100644 100644 f025ee9... f6bd5b5... M
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java
:100644 100644 49bf607... fcbb475... M
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java
:100644 100644 b08f7ab... 1bbba8a... M
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java
:100644 100644 eac87b8... 8a5aee8... M
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java
:100644 100644 62be8f4... 16b3125... M
server/src/main/java/org/apache/sqoop/handler/ConnectionRequestHandler.java
:100644 100644 0d15329... 816ba58... M
server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java
:100644 100644 65686a8... 1069916... M
server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java
Diffs (updated)
-----
client/src/main/java/org/apache/sqoop/client/core/Constants.java 999790d
client/src/main/java/org/apache/sqoop/client/shell/ShowConnectionFunction.java
94f92b3
client/src/main/java/org/apache/sqoop/client/shell/ShowJobFunction.java
97a240b
client/src/main/java/org/apache/sqoop/client/utils/SubmissionDisplayer.java
cbc956d
client/src/main/resources/client-resource.properties 1a8f963
common/src/main/java/org/apache/sqoop/json/ConnectionBean.java a014ddd
common/src/main/java/org/apache/sqoop/json/JobBean.java 4685797
common/src/main/java/org/apache/sqoop/json/SubmissionBean.java 79490f8
common/src/main/java/org/apache/sqoop/json/util/FormSerialization.java
3daf8d2
common/src/main/java/org/apache/sqoop/model/MAccountableEntity.java 5524983
common/src/test/java/org/apache/sqoop/json/TestConnectionBean.java 2f2b974
common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java 3b56171
common/src/test/java/org/apache/sqoop/model/TestMAccountableEntity.java
bf103e4
core/src/main/java/org/apache/sqoop/framework/JobManager.java d0a087d
core/src/main/java/org/apache/sqoop/request/HttpEventContext.java
PRE-CREATION
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java
f025ee9
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java
49bf607
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java
b08f7ab
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java
eac87b8
server/src/main/java/org/apache/sqoop/handler/ConnectionRequestHandler.java
62be8f4
server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 0d15329
server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java
65686a8
Diff: https://reviews.apache.org/r/12713/diff/
Testing
-------
Unit tests for 'common' module passed. I also did several manual tests to check
the new functionalities.
Thanks,
Mengwei Ding
