-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12713/#review25190
-----------------------------------------------------------

Ship it!


Ship It!

- Jarek Cecho


On Aug. 14, 2013, 8:42 p.m., Mengwei Ding wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12713/
> -----------------------------------------------------------
> 
> (Updated Aug. 14, 2013, 8:42 p.m.)
> 
> 
> Review request for Sqoop, Abraham Elmahrek, Hari Shreedharan, and Jarek Cecho.
> 
> 
> Bugs: SQOOP-1142
>     https://issues.apache.org/jira/browse/SQOOP-1142
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> commit a0121f728cbdc02bc3cba3dde462f817c4694f9f
> Author: Mengwei Ding <[email protected]>
> Date:   Wed Jul 17 10:48:05 2013 -0700
> 
>     SQOOP-1142 Sqoop2: Provide creater and last edited by to metadata 
> structures
> 
> :100644 100644 a014ddd... 688bb64... M        
> common/src/main/java/org/apache/sqoop/json/ConnectionBean.java
> :100644 100644 4685797... 1555bd5... M        
> common/src/main/java/org/apache/sqoop/json/JobBean.java
> :100644 100644 79490f8... 61d6576... M        
> common/src/main/java/org/apache/sqoop/json/SubmissionBean.java
> :100644 100644 3daf8d2... 9558941... M        
> common/src/main/java/org/apache/sqoop/json/util/FormSerialization.java
> :100644 100644 5524983... 8af7c15... M        
> common/src/main/java/org/apache/sqoop/model/MAccountableEntity.java
> :100644 100644 2f2b974... 19f81a8... M        
> common/src/test/java/org/apache/sqoop/json/TestConnectionBean.java
> :100644 100644 3b56171... d87655e... M        
> common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java
> :100644 100644 bf103e4... f3d4166... M        
> common/src/test/java/org/apache/sqoop/model/TestMAccountableEntity.java
> :100644 100644 d0a087d... e052584... M        
> core/src/main/java/org/apache/sqoop/framework/JobManager.java
> :000000 100644 0000000... fda75eb... A        
> core/src/main/java/org/apache/sqoop/request/HttpEventContext.java
> :100644 100644 f025ee9... f6bd5b5... M        
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java
> :100644 100644 49bf607... fcbb475... M        
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java
> :100644 100644 b08f7ab... 1bbba8a... M        
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java
> :100644 100644 eac87b8... 8a5aee8... M        
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java
> :100644 100644 875729f... c9c7648... M        
> server/src/main/java/org/apache/sqoop/handler/ConnectionRequestHandler.java
> :100644 100644 59a4511... 362ba79... M        
> server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java
> :100644 100644 6d9777a... 6e21dd9... M        
> server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java
> :100644 100644 b7204ff... b55d5d1... M        
> shell/src/main/java/org/apache/sqoop/shell/ShowConnectionFunction.java
> :100644 100644 fc6f416... da4a4ff... M        
> shell/src/main/java/org/apache/sqoop/shell/ShowJobFunction.java
> :100644 100644 0e33d42... 475f41c... M        
> shell/src/main/java/org/apache/sqoop/shell/core/Constants.java
> :100644 100644 1f61fb2... 6dbd870... M        
> shell/src/main/java/org/apache/sqoop/shell/utils/SubmissionDisplayer.java
> :100644 100644 1a8f963... df9457d... M        
> shell/src/main/resources/shell-resource.properties
> 
> 
> Diffs
> -----
> 
>   common/src/main/java/org/apache/sqoop/json/ConnectionBean.java a014ddd 
>   common/src/main/java/org/apache/sqoop/json/JobBean.java 4685797 
>   common/src/main/java/org/apache/sqoop/json/SubmissionBean.java 79490f8 
>   common/src/main/java/org/apache/sqoop/json/util/FormSerialization.java 
> 3daf8d2 
>   common/src/main/java/org/apache/sqoop/model/MAccountableEntity.java 5524983 
>   common/src/test/java/org/apache/sqoop/json/TestConnectionBean.java 2f2b974 
>   common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java 3b56171 
>   common/src/test/java/org/apache/sqoop/model/TestMAccountableEntity.java 
> bf103e4 
>   core/src/main/java/org/apache/sqoop/framework/JobManager.java d0a087d 
>   core/src/main/java/org/apache/sqoop/request/HttpEventContext.java 
> PRE-CREATION 
>   
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java
>  f025ee9 
>   
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java
>  49bf607 
>   
> repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java
>  b08f7ab 
>   
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java
>  eac87b8 
>   server/src/main/java/org/apache/sqoop/handler/ConnectionRequestHandler.java 
> 875729f 
>   server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 
> 59a4511 
>   server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java 
> 6d9777a 
>   shell/src/main/java/org/apache/sqoop/shell/ShowConnectionFunction.java 
> b7204ff 
>   shell/src/main/java/org/apache/sqoop/shell/ShowJobFunction.java fc6f416 
>   shell/src/main/java/org/apache/sqoop/shell/core/Constants.java 0e33d42 
>   shell/src/main/java/org/apache/sqoop/shell/utils/SubmissionDisplayer.java 
> 1f61fb2 
>   shell/src/main/resources/shell-resource.properties 1a8f963 
> 
> Diff: https://reviews.apache.org/r/12713/diff/
> 
> 
> Testing
> -------
> 
> Unit tests for 'common' module passed. I also did several manual tests to 
> check the new functionalities.
> 
> 
> Thanks,
> 
> Mengwei Ding
> 
>

Reply via email to