----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13636/#review25279 -----------------------------------------------------------
Hi Erik, the changes looks about right. Would you mind adding test to TestClassWriter to ensure that we want regress from this functionality? Jarcec - Jarek Cecho On Aug. 18, 2013, 4:20 p.m., Erik Selin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13636/ > ----------------------------------------------------------- > > (Updated Aug. 18, 2013, 4:20 p.m.) > > > Review request for Sqoop. > > > Bugs: https://issues.apache.org/jira/browse/SQOOP-1170 > > https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/SQOOP-1170 > > > Repository: sqoop-trunk > > > Description > ------- > > Adds public to JAVA_RESERVED_WORDS. This should allow for importing tables > with columns named "public". > > > Diffs > ----- > > src/java/com/cloudera/sqoop/orm/ClassWriter.java 61ff054 > src/java/org/apache/sqoop/orm/ClassWriter.java 4cb4b78 > > Diff: https://reviews.apache.org/r/13636/diff/ > > > Testing > ------- > > > Thanks, > > Erik Selin > >
