> On Aug. 18, 2013, 7 p.m., Jarek Cecho wrote:
> > Hi Erik,
> > the changes looks about right. Would you mind adding test to
> > TestClassWriter to ensure that we want regress from this functionality?
> >
> > Jarcec
>
> Erik Selin wrote:
> Hey, I sure could but this is such a tiny change I don't really see what
> you would like me to test for? I could add a line to
>
> assertEquals("_public", ClassWriter.toJavaIdentifier("public"));
>
> but that just seems redundant since we're not testing for any of the
> other JAVA_RESERVED_WORDS?
I think that we actually should be doing exactly that, so If you feel up to,
don't hesitate and add the tests for all entries from JAVA_RESERVED_WORDS.
Otherwise please just add this one and we will create follow up JIRA to add the
others.
- Jarek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13636/#review25279
-----------------------------------------------------------
On Aug. 18, 2013, 4:20 p.m., Erik Selin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13636/
> -----------------------------------------------------------
>
> (Updated Aug. 18, 2013, 4:20 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: https://issues.apache.org/jira/browse/SQOOP-1170
>
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/SQOOP-1170
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> Adds public to JAVA_RESERVED_WORDS. This should allow for importing tables
> with columns named "public".
>
>
> Diffs
> -----
>
> src/java/com/cloudera/sqoop/orm/ClassWriter.java 61ff054
> src/java/org/apache/sqoop/orm/ClassWriter.java 4cb4b78
>
> Diff: https://reviews.apache.org/r/13636/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Erik Selin
>
>
