----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14351/#review26538 -----------------------------------------------------------
Hi Abe, thank you very much for incorporating the upgrade path to the patch, appreciated! I do have one question: repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java <https://reviews.apache.org/r/14351/#comment51785> I think that this change is not necessary as the version "2" will be correctly detected in "normal version detection" block that is starting just after this block that is there specifically for pre 1.99.2 repository structures, right? Jarcec - Jarek Cecho On Sept. 27, 2013, 11:02 p.m., Abraham Elmahrek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14351/ > ----------------------------------------------------------- > > (Updated Sept. 27, 2013, 11:02 p.m.) > > > Review request for Sqoop, Hari Shreedharan and Jarek Cecho. > > > Bugs: SQOOP-1208 > https://issues.apache.org/jira/browse/SQOOP-1208 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > commit eb0e73f08c80859c979aac17cf8df8522b43368a > Author: Abraham Elmahrek <[email protected]> > Date: Thu Sep 26 12:59:42 2013 -0700 > > SQOOP-1208 Sqoop2: job ID column is too small > > Increased it to 50 > > :100644 100644 bb01f03... 200293d... M > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepoConstants.java > :100644 100644 f6bd5b5... 331780b... M > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java > :100644 100644 0a196f0... b86d5f8... M > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java > > > Diffs > ----- > > > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepoConstants.java > bb01f0308499145e20ebebae1473591ba17227d0 > > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java > f6bd5b5c560486f85db0676ae74544a8c8420b51 > > repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java > 0a196f03a39fd0c802de643988b73fc804ec68e1 > > Diff: https://reviews.apache.org/r/14351/diff/ > > > Testing > ------- > > Ran sqoop tests and verified fix locally. > > > Thanks, > > Abraham Elmahrek > >
