> On Nov. 5, 2013, 6:11 a.m., Sean Busbey wrote: > > src/test/org/apache/sqoop/accumulo/AccumuloTestCase.java, lines 156-163 > > <https://reviews.apache.org/r/8559/diff/7/?file=377378#file377378line156> > > > > This will make sure we only attempt setupCluster once concurrently, but > > it won't make parallel tests wait for the cluster to finish. > > > > Why don't we mimic the HBase tests, and just spin up and take down the > > mini cluster for each test. Does that take too long? > > > > If a minicluster per test does take too long, I'd say it's not worth > > building the complexity to handle parallel tests correctly when e.g. the > > hbase tests don't. Just switch to a non-concurrent int (to keep the cleanup > > in @After) so it's obviously not threadsafe when future maintainers look at > > it. > > > > (sorry for the thrashing)
Too long is kind of subjective. I have it spinning up for each test now, and the TestAccumuloImport suite takes 34 seconds in a VM on my laptop. I don't know if that's too long or not, but I'm going with it. - Philip ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8559/#review28173 ----------------------------------------------------------- On Nov. 4, 2013, 11 p.m., Philip Grim wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8559/ > ----------------------------------------------------------- > > (Updated Nov. 4, 2013, 11 p.m.) > > > Review request for accumulo, Sqoop and Jarek Cecho. > > > Repository: sqoop-trunk > > > Description > ------- > > Adds the ability to import to an Accumulo table in much the same manner as > the current HBase import capability. Reported in JIRA as ACCUMULO-141 and > SQOOP-767. > > > Diffs > ----- > > ivy.xml c5130ae > src/docs/user/accumulo-args.txt PRE-CREATION > src/docs/user/accumulo.txt PRE-CREATION > src/java/org/apache/sqoop/SqoopOptions.java 13637b5 > src/java/org/apache/sqoop/accumulo/AccumuloMutationProcessor.java > PRE-CREATION > src/java/org/apache/sqoop/accumulo/AccumuloUtil.java PRE-CREATION > src/java/org/apache/sqoop/accumulo/MutationTransformer.java PRE-CREATION > src/java/org/apache/sqoop/accumulo/ToStringMutationTransformer.java > PRE-CREATION > src/java/org/apache/sqoop/manager/SqlManager.java 1ffa40f > src/java/org/apache/sqoop/mapreduce/AccumuloImportJob.java PRE-CREATION > src/java/org/apache/sqoop/mapreduce/AccumuloImportMapper.java PRE-CREATION > src/java/org/apache/sqoop/tool/BaseSqoopTool.java 9230f82 > src/java/org/apache/sqoop/tool/ImportTool.java fbbde1d > src/test/org/apache/sqoop/accumulo/AccumuloTestCase.java PRE-CREATION > src/test/org/apache/sqoop/accumulo/TestAccumuloImport.java PRE-CREATION > src/test/org/apache/sqoop/accumulo/TestAccumuloQueryImport.java > PRE-CREATION > src/test/org/apache/sqoop/accumulo/TestAccumuloUtil.java PRE-CREATION > > Diff: https://reviews.apache.org/r/8559/diff/ > > > Testing > ------- > > > Thanks, > > Philip Grim > >
