----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8559/#review28271 -----------------------------------------------------------
Hi Philip, I do have couple of nits: src/docs/user/accumulo.txt <https://reviews.apache.org/r/8559/#comment55042> Nit: I believe that there is missing dash in the "--accumulo password" parameter? src/java/org/apache/sqoop/SqoopOptions.java <https://reviews.apache.org/r/8559/#comment55043> Nit: Unnecessary // src/java/org/apache/sqoop/SqoopOptions.java <https://reviews.apache.org/r/8559/#comment55044> Nit: Please put space between "//" and the comment itself. src/java/org/apache/sqoop/SqoopOptions.java <https://reviews.apache.org/r/8559/#comment55045> Nit: Please put space between "//" and the comment itself. src/java/org/apache/sqoop/SqoopOptions.java <https://reviews.apache.org/r/8559/#comment55046> Nit: Please put space between "//" and the comment itself. src/java/org/apache/sqoop/SqoopOptions.java <https://reviews.apache.org/r/8559/#comment55047> Nit: Please put space between "//" and the comment itself. src/java/org/apache/sqoop/accumulo/AccumuloUtil.java <https://reviews.apache.org/r/8559/#comment55263> Nit: Can we put the class name into constant? src/java/org/apache/sqoop/tool/BaseSqoopTool.java <https://reviews.apache.org/r/8559/#comment55276> Nit: Wouldn't be simpler to verify that FileLayout have to be the default one rather then verifying every other possibility? src/java/org/apache/sqoop/tool/BaseSqoopTool.java <https://reviews.apache.org/r/8559/#comment55277> Would it be valid situation for the password to be missing? Jarcec - Jarek Cecho On Nov. 5, 2013, 9:11 p.m., Philip Grim wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8559/ > ----------------------------------------------------------- > > (Updated Nov. 5, 2013, 9:11 p.m.) > > > Review request for accumulo, Sqoop and Jarek Cecho. > > > Repository: sqoop-trunk > > > Description > ------- > > Adds the ability to import to an Accumulo table in much the same manner as > the current HBase import capability. Reported in JIRA as ACCUMULO-141 and > SQOOP-767. > > > Diffs > ----- > > ivy.xml c5130ae > src/docs/user/accumulo-args.txt PRE-CREATION > src/docs/user/accumulo.txt PRE-CREATION > src/java/org/apache/sqoop/SqoopOptions.java 5c7a56a > src/java/org/apache/sqoop/accumulo/AccumuloMutationProcessor.java > PRE-CREATION > src/java/org/apache/sqoop/accumulo/AccumuloUtil.java PRE-CREATION > src/java/org/apache/sqoop/accumulo/MutationTransformer.java PRE-CREATION > src/java/org/apache/sqoop/accumulo/ToStringMutationTransformer.java > PRE-CREATION > src/java/org/apache/sqoop/manager/SqlManager.java 1ffa40f > src/java/org/apache/sqoop/mapreduce/AccumuloImportJob.java PRE-CREATION > src/java/org/apache/sqoop/mapreduce/AccumuloImportMapper.java PRE-CREATION > src/java/org/apache/sqoop/tool/BaseSqoopTool.java 018d11f > src/java/org/apache/sqoop/tool/ImportTool.java fbbde1d > src/test/org/apache/sqoop/accumulo/AccumuloTestCase.java PRE-CREATION > src/test/org/apache/sqoop/accumulo/TestAccumuloImport.java PRE-CREATION > src/test/org/apache/sqoop/accumulo/TestAccumuloQueryImport.java > PRE-CREATION > src/test/org/apache/sqoop/accumulo/TestAccumuloUtil.java PRE-CREATION > > Diff: https://reviews.apache.org/r/8559/diff/ > > > Testing > ------- > > > Thanks, > > Philip Grim > >
