----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15639/#review29040 -----------------------------------------------------------
Only one edge to discuss really... see comment below! core/src/main/java/org/apache/sqoop/framework/SubmissionRequest.java <https://reviews.apache.org/r/15639/#comment56122> The only problem I see here is that the order that jars are included could make the wrong class be used (or wrong version). Maybe instead of not appending the jar, we can remove the jar from the list and append it to the end of the list? core/src/test/java/org/apache/sqoop/framework/TestSubmissionRequest.java <https://reviews.apache.org/r/15639/#comment56123> testAddJarForClass (capital L) submission/mapreduce/src/main/java/org/apache/sqoop/submission/mapreduce/MapreduceSubmissionEngine.java <https://reviews.apache.org/r/15639/#comment56124> +1!!! - Abraham Elmahrek On Nov. 18, 2013, 3:19 a.m., Jarek Cecho wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15639/ > ----------------------------------------------------------- > > (Updated Nov. 18, 2013, 3:19 a.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-1236 > https://issues.apache.org/jira/browse/SQOOP-1236 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > Added code that will ensure that only unique entries will be present in the > classpath. I've also used StringUtils.join() to merge all the entries for use > (instead of home made version of the same). > > > Diffs > ----- > > core/src/main/java/org/apache/sqoop/framework/SubmissionRequest.java > 53d003980a172e4e0acf18630a3496909c17cb5c > core/src/test/java/org/apache/sqoop/framework/TestSubmissionRequest.java > PRE-CREATION > > submission/mapreduce/src/main/java/org/apache/sqoop/submission/mapreduce/MapreduceSubmissionEngine.java > 6fc485b66ea8c33d09d172675a104954d570f3a7 > > Diff: https://reviews.apache.org/r/15639/diff/ > > > Testing > ------- > > Unit tests seems to be passing. > > > Thanks, > > Jarek Cecho > >
