----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15639/#review29602 -----------------------------------------------------------
Ship it! Ship It! - Abraham Elmahrek On Dec. 2, 2013, 5:21 p.m., Jarek Cecho wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15639/ > ----------------------------------------------------------- > > (Updated Dec. 2, 2013, 5:21 p.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-1236 > https://issues.apache.org/jira/browse/SQOOP-1236 > > > Repository: sqoop-sqoop2 > > > Description > ------- > > Added code that will ensure that only unique entries will be present in the > classpath. I've also used StringUtils.join() to merge all the entries for use > (instead of home made version of the same). > > > Diffs > ----- > > core/src/main/java/org/apache/sqoop/framework/SubmissionRequest.java > 53d003980a172e4e0acf18630a3496909c17cb5c > core/src/test/java/org/apache/sqoop/framework/TestSubmissionRequest.java > PRE-CREATION > > submission/mapreduce/src/main/java/org/apache/sqoop/submission/mapreduce/MapreduceSubmissionEngine.java > 6fc485b66ea8c33d09d172675a104954d570f3a7 > > Diff: https://reviews.apache.org/r/15639/diff/ > > > Testing > ------- > > Unit tests seems to be passing. > > > Thanks, > > Jarek Cecho > >
