----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25936/#review54305 -----------------------------------------------------------
Also, as a note on style, I think some of the imports are out of order or the spacing is a little off. Just a nit... not important I'd say! execution/mapreduce/src/test/java/org/apache/sqoop/job/TestMapReduce.java <https://reviews.apache.org/r/25936/#comment94388> Needs @Test annotation? execution/mapreduce/src/test/java/org/apache/sqoop/job/TestMapReduce.java <https://reviews.apache.org/r/25936/#comment94389> Needs @Test annotation? - Abraham Elmahrek On Sept. 23, 2014, 9:55 a.m., Chiwan Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25936/ > ----------------------------------------------------------- > > (Updated Sept. 23, 2014, 9:55 a.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-1478 > https://issues.apache.org/jira/browse/SQOOP-1478 > > > Repository: sqoop-SQOOP-1367 > > > Description > ------- > > Migrate all tests from junit 3 to 4. > > 1. Remove extends "TestCase" and add @Test annotation to all test method. > 2. Change from "junit.framework.Assert" to "org.junit.Assert". > 3. Change from "assertEquals(double, double)" to "assertEquals(double, > double, double)" with epsilon 0.01. > 4. Add @Before annotation to setUp method. > 5. Add @After annotation to tearDown method. > > > Diffs > ----- > > common/src/test/java/org/apache/sqoop/common/TestMapContext.java f4718c0 > common/src/test/java/org/apache/sqoop/json/TestConnectionBean.java 19f81a8 > common/src/test/java/org/apache/sqoop/json/TestJobBean.java 3106d39 > common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java 518c9cb > common/src/test/java/org/apache/sqoop/json/TestValidationResultBean.java > d9c2043 > common/src/test/java/org/apache/sqoop/model/TestFormUtils.java ba85d11 > common/src/test/java/org/apache/sqoop/model/TestMFormList.java c7ee682 > common/src/test/java/org/apache/sqoop/submission/TestSubmissionStatus.java > 99f4767 > > common/src/test/java/org/apache/sqoop/submission/counter/TestCounterGroup.java > 985009a > common/src/test/java/org/apache/sqoop/submission/counter/TestCounters.java > 8f8d617 > common/src/test/java/org/apache/sqoop/validation/TestStatus.java 5b17a4e > common/src/test/java/org/apache/sqoop/validation/TestValidation.java > bf0ade5 > > common/src/test/java/org/apache/sqoop/validation/validators/TestContains.java > b5dce62 > > common/src/test/java/org/apache/sqoop/validation/validators/TestNullOrContains.java > 4bd1559 > > common/src/test/java/org/apache/sqoop/validation/validators/TestStartsWith.java > 92409d9 > > connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/GenericJdbcExecutorTest.java > e10a5b4 > > connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestExtractor.java > 2b1dec2 > > connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestFromInitializer.java > 2d07130 > > connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestPartitioner.java > f1023c8 > > connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestToInitializer.java > 4767215 > execution/mapreduce/src/test/java/org/apache/sqoop/job/JobUtils.java > 09e5ec5 > execution/mapreduce/src/test/java/org/apache/sqoop/job/TestMapReduce.java > 869c727 > > execution/mapreduce/src/test/java/org/apache/sqoop/job/io/SqoopWritableTest.java > b78b140 > execution/mapreduce/src/test/java/org/apache/sqoop/job/io/TestData.java > 91df426 > > execution/mapreduce/src/test/java/org/apache/sqoop/job/mr/TestSqoopOutputFormatLoadExecutor.java > c2ebd7e > > repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java > 29da340 > > repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestConnectionHandling.java > f9e9217 > > repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestConnectorHandling.java > 745e128 > > repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestFrameworkHandling.java > 006ec9c > > repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestInputTypes.java > 15f9539 > > repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestInternals.java > 913439b > > repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestJobHandling.java > e658c11 > > repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestSubmissionHandling.java > 8fce0dd > test/src/test/java/org/apache/sqoop/integration/server/VersionTest.java > cea24b9 > > Diff: https://reviews.apache.org/r/25936/diff/ > > > Testing > ------- > > Tested with command "mvn test". > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Sqoop ............................................. SUCCESS [0.621s] > [INFO] Sqoop Common ...................................... SUCCESS [18.900s] > [INFO] Sqoop Connectors .................................. SUCCESS [0.021s] > [INFO] Sqoop Connector SDK ............................... SUCCESS [0.459s] > [INFO] Sqoop SPI ......................................... SUCCESS [0.107s] > [INFO] Sqoop Core ........................................ SUCCESS [3.005s] > [INFO] Sqoop Repository .................................. SUCCESS [0.014s] > [INFO] Sqoop Derby Repository ............................ SUCCESS [45.859s] > [INFO] Sqoop Tools ....................................... SUCCESS [0.104s] > [INFO] Sqoop Execution Engines ........................... SUCCESS [0.011s] > [INFO] Sqoop Mapreduce Execution Engine .................. SUCCESS [8.874s] > [INFO] Sqoop Submission Engines .......................... SUCCESS [0.015s] > [INFO] Sqoop Mapreduce Submission Engine ................. SUCCESS [0.163s] > [INFO] Sqoop Generic JDBC Connector ...................... SUCCESS [19.537s] > [INFO] Sqoop HDFS Connector .............................. SUCCESS [8.422s] > [INFO] Sqoop Server ...................................... SUCCESS [0.392s] > [INFO] Sqoop Client ...................................... SUCCESS [0.757s] > [INFO] Sqoop Shell ....................................... SUCCESS [0.657s] > [INFO] Sqoop Documentation ............................... SUCCESS [0.434s] > [INFO] Sqoop Tomcat additions ............................ SUCCESS [0.126s] > [INFO] Sqoop Distribution ................................ SUCCESS [0.076s] > [INFO] Sqoop Integration Tests ........................... SUCCESS [1.585s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 1:50.618s > [INFO] Finished at: Tue Sep 23 18:29:10 KST 2014 > [INFO] Final Memory: 33M/96M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Chiwan Park > >
