> On Sept. 29, 2014, 6 p.m., Abraham Elmahrek wrote: > > Please rebase your patch!
My mistake... no rebase needed! - Abraham ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25936/#review54836 ----------------------------------------------------------- On Sept. 25, 2014, 10:37 a.m., Chiwan Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25936/ > ----------------------------------------------------------- > > (Updated Sept. 25, 2014, 10:37 a.m.) > > > Review request for Sqoop. > > > Bugs: SQOOP-1478 > https://issues.apache.org/jira/browse/SQOOP-1478 > > > Repository: sqoop-SQOOP-1367 > > > Description > ------- > > Migrate all tests from junit 3 to 4. > > 1. Remove extends "TestCase" and add @Test annotation to all test method. > 2. Change from "junit.framework.Assert" to "org.junit.Assert". > 3. Change from "assertEquals(double, double)" to "assertEquals(double, > double, double)" with epsilon 0.01. > 4. Add @Before annotation to setUp method. > 5. Add @After annotation to tearDown method. > > > Diffs > ----- > > common/src/test/java/org/apache/sqoop/common/TestMapContext.java f4718c0 > common/src/test/java/org/apache/sqoop/json/TestConnectorBean.java e078474 > common/src/test/java/org/apache/sqoop/json/TestDriverConfigBean.java > 4309f10 > common/src/test/java/org/apache/sqoop/json/TestJobBean.java c6461bf > common/src/test/java/org/apache/sqoop/json/TestLinkBean.java 8235275 > common/src/test/java/org/apache/sqoop/json/TestSchemaBean.java 5daab76 > common/src/test/java/org/apache/sqoop/json/TestSubmissionBean.java 518c9cb > common/src/test/java/org/apache/sqoop/json/TestValidationResultBean.java > d9c2043 > common/src/test/java/org/apache/sqoop/model/TestFormUtils.java ba85d11 > common/src/test/java/org/apache/sqoop/model/TestMAccountableEntity.java > d56e165 > common/src/test/java/org/apache/sqoop/model/TestMBooleanInput.java cf9cf24 > common/src/test/java/org/apache/sqoop/model/TestMConnectionForms.java > e2d2717 > common/src/test/java/org/apache/sqoop/model/TestMConnector.java 0a5fd90 > common/src/test/java/org/apache/sqoop/model/TestMEnumInput.java a25016a > common/src/test/java/org/apache/sqoop/model/TestMForm.java 0bd55d9 > common/src/test/java/org/apache/sqoop/model/TestMFormList.java c7ee682 > common/src/test/java/org/apache/sqoop/model/TestMIntegerInput.java 1f38e6d > common/src/test/java/org/apache/sqoop/model/TestMJob.java 96c316a > common/src/test/java/org/apache/sqoop/model/TestMJobForms.java 81a8614 > common/src/test/java/org/apache/sqoop/model/TestMLink.java 1be37a1 > common/src/test/java/org/apache/sqoop/model/TestMMapInput.java 120fb07 > common/src/test/java/org/apache/sqoop/model/TestMNamedElement.java f336bab > common/src/test/java/org/apache/sqoop/model/TestMPersistableEntity.java > 000c6be > common/src/test/java/org/apache/sqoop/model/TestMStringInput.java 2fe0335 > common/src/test/java/org/apache/sqoop/model/TestMValidatedElement.java > cf34983 > common/src/test/java/org/apache/sqoop/submission/TestSubmissionStatus.java > 99f4767 > > common/src/test/java/org/apache/sqoop/submission/counter/TestCounterGroup.java > 985009a > common/src/test/java/org/apache/sqoop/submission/counter/TestCounters.java > 8f8d617 > common/src/test/java/org/apache/sqoop/utils/TestClassUtils.java 16c2015 > common/src/test/java/org/apache/sqoop/validation/TestStatus.java 5b17a4e > common/src/test/java/org/apache/sqoop/validation/TestValidation.java > bf0ade5 > > common/src/test/java/org/apache/sqoop/validation/validators/TestContains.java > b5dce62 > > common/src/test/java/org/apache/sqoop/validation/validators/TestNullOrContains.java > 4bd1559 > > common/src/test/java/org/apache/sqoop/validation/validators/TestStartsWith.java > 92409d9 > > connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/GenericJdbcExecutorTest.java > e10a5b4 > > connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestExtractor.java > 776359a > > connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestFromInitializer.java > bf66bb1 > > connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestLoader.java > c349676 > > connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestPartitioner.java > 949877b > > connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestToInitializer.java > 00c2aab > core/src/test/java/org/apache/sqoop/driver/TestJobManager.java 80f45e5 > core/src/test/java/org/apache/sqoop/driver/TestJobRequest.java 768c978 > core/src/test/java/org/apache/sqoop/repository/TestJdbcRepository.java > 796b021 > execution/mapreduce/src/test/java/org/apache/sqoop/job/JobUtils.java > 09e5ec5 > execution/mapreduce/src/test/java/org/apache/sqoop/job/TestMapReduce.java > 869c727 > > execution/mapreduce/src/test/java/org/apache/sqoop/job/io/SqoopWritableTest.java > b78b140 > execution/mapreduce/src/test/java/org/apache/sqoop/job/io/TestData.java > 91df426 > > execution/mapreduce/src/test/java/org/apache/sqoop/job/mr/TestSqoopOutputFormatLoadExecutor.java > c2ebd7e > > repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java > 998f5b7 > > repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestConnectorHandling.java > 8a5823d > > repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestDriverConfigHandling.java > 567dda6 > > repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestInputTypes.java > c4a5829 > > repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestInternals.java > 37aa8d4 > > repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestJobHandling.java > f22c351 > > repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestLinkHandling.java > 7378eda > > repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestSubmissionHandling.java > 38a995f > > Diff: https://reviews.apache.org/r/25936/diff/ > > > Testing > ------- > > Tested with command "mvn test". > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Sqoop ............................................. SUCCESS [0.621s] > [INFO] Sqoop Common ...................................... SUCCESS [18.900s] > [INFO] Sqoop Connectors .................................. SUCCESS [0.021s] > [INFO] Sqoop Connector SDK ............................... SUCCESS [0.459s] > [INFO] Sqoop SPI ......................................... SUCCESS [0.107s] > [INFO] Sqoop Core ........................................ SUCCESS [3.005s] > [INFO] Sqoop Repository .................................. SUCCESS [0.014s] > [INFO] Sqoop Derby Repository ............................ SUCCESS [45.859s] > [INFO] Sqoop Tools ....................................... SUCCESS [0.104s] > [INFO] Sqoop Execution Engines ........................... SUCCESS [0.011s] > [INFO] Sqoop Mapreduce Execution Engine .................. SUCCESS [8.874s] > [INFO] Sqoop Submission Engines .......................... SUCCESS [0.015s] > [INFO] Sqoop Mapreduce Submission Engine ................. SUCCESS [0.163s] > [INFO] Sqoop Generic JDBC Connector ...................... SUCCESS [19.537s] > [INFO] Sqoop HDFS Connector .............................. SUCCESS [8.422s] > [INFO] Sqoop Server ...................................... SUCCESS [0.392s] > [INFO] Sqoop Client ...................................... SUCCESS [0.757s] > [INFO] Sqoop Shell ....................................... SUCCESS [0.657s] > [INFO] Sqoop Documentation ............................... SUCCESS [0.434s] > [INFO] Sqoop Tomcat additions ............................ SUCCESS [0.126s] > [INFO] Sqoop Distribution ................................ SUCCESS [0.076s] > [INFO] Sqoop Integration Tests ........................... SUCCESS [1.585s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 1:50.618s > [INFO] Finished at: Tue Sep 23 18:29:10 KST 2014 > [INFO] Final Memory: 33M/96M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Chiwan Park > >
