-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26145/
-----------------------------------------------------------
Review request for Sqoop.
Bugs: SQOOP-1498
https://issues.apache.org/jira/browse/SQOOP-1498
Repository: sqoop-SQOOP-1367
Description
-------
Sqoop2 Repository Object refactoring
- see JIRA for the details on the changes to the model objects MConnector,
MJob, MLink, M*Config
- rename forms to configs
- renames to the db repository to accomodate the renames in models/ fields
-
Diffs
-----
client/src/main/java/org/apache/sqoop/client/SqoopClient.java d7e6768
client/src/main/java/org/apache/sqoop/client/request/DriverConfigResourceRequest.java
7b2ddc2
client/src/test/java/org/apache/sqoop/client/TestSqoopClient.java 54ea3d2
common/src/main/java/org/apache/sqoop/json/ConnectorBean.java 465dd69
common/src/main/java/org/apache/sqoop/json/DriverConfigBean.java a2cc8b8
common/src/main/java/org/apache/sqoop/json/JobBean.java a3e6071
common/src/main/java/org/apache/sqoop/json/JobValidationBean.java 34c0a4b
common/src/main/java/org/apache/sqoop/json/LinkBean.java 8981ea7
common/src/main/java/org/apache/sqoop/json/LinkValidationBean.java a6a6b65
common/src/main/java/org/apache/sqoop/json/util/ConfigSerialization.java
PRE-CREATION
common/src/main/java/org/apache/sqoop/json/util/FormSerialization.java
77f6191
common/src/main/java/org/apache/sqoop/json/util/ResourceBundleSerialization.java
20ee5f3
common/src/main/java/org/apache/sqoop/model/Config.java PRE-CREATION
common/src/main/java/org/apache/sqoop/model/ConfigClass.java PRE-CREATION
common/src/main/java/org/apache/sqoop/model/ConfigUtils.java PRE-CREATION
common/src/main/java/org/apache/sqoop/model/ConfigurationClass.java 73374d8
common/src/main/java/org/apache/sqoop/model/ConfigurationGroupClass.java
PRE-CREATION
common/src/main/java/org/apache/sqoop/model/Form.java 4321582
common/src/main/java/org/apache/sqoop/model/FormClass.java 6048d03
common/src/main/java/org/apache/sqoop/model/FormUtils.java ae025ab
common/src/main/java/org/apache/sqoop/model/MConfig.java PRE-CREATION
common/src/main/java/org/apache/sqoop/model/MConfigList.java PRE-CREATION
common/src/main/java/org/apache/sqoop/model/MConfigType.java PRE-CREATION
common/src/main/java/org/apache/sqoop/model/MConnectionForms.java 457ccdb
common/src/main/java/org/apache/sqoop/model/MConnector.java 3dc1014
common/src/main/java/org/apache/sqoop/model/MDriverConfig.java 62eb197
common/src/main/java/org/apache/sqoop/model/MForm.java ff94660
common/src/main/java/org/apache/sqoop/model/MFormList.java 9130ada
common/src/main/java/org/apache/sqoop/model/MFormType.java 2f403df
common/src/main/java/org/apache/sqoop/model/MFromConfig.java PRE-CREATION
common/src/main/java/org/apache/sqoop/model/MJob.java c9b45a5
common/src/main/java/org/apache/sqoop/model/MJobForms.java 08b9a78
common/src/main/java/org/apache/sqoop/model/MLink.java 6a8c424
common/src/main/java/org/apache/sqoop/model/MLinkConfig.java PRE-CREATION
common/src/main/java/org/apache/sqoop/model/MToConfig.java PRE-CREATION
common/src/main/java/org/apache/sqoop/validation/Validation.java fce6e88
common/src/main/java/org/apache/sqoop/validation/ValidationError.java 264d6e3
common/src/main/java/org/apache/sqoop/validation/ValidationRunner.java
f36faf2
common/src/test/java/org/apache/sqoop/json/ConfigTestUtil.java PRE-CREATION
common/src/test/java/org/apache/sqoop/json/TestConnectorBean.java e078474
common/src/test/java/org/apache/sqoop/json/TestDriverConfigBean.java 4309f10
common/src/test/java/org/apache/sqoop/json/TestJobBean.java c6461bf
common/src/test/java/org/apache/sqoop/json/TestLinkBean.java 8235275
common/src/test/java/org/apache/sqoop/json/TestUtil.java eaf9122
common/src/test/java/org/apache/sqoop/json/TestValidationBean.java f5f3389
common/src/test/java/org/apache/sqoop/json/util/TestConfigSerialization.java
PRE-CREATION
common/src/test/java/org/apache/sqoop/json/util/TestFormSerialization.java
c4223ec
common/src/test/java/org/apache/sqoop/model/TestConfigUtils.java PRE-CREATION
common/src/test/java/org/apache/sqoop/model/TestFormUtils.java ba85d11
common/src/test/java/org/apache/sqoop/model/TestMAccountableEntity.java
d56e165
common/src/test/java/org/apache/sqoop/model/TestMConfig.java PRE-CREATION
common/src/test/java/org/apache/sqoop/model/TestMConfigList.java PRE-CREATION
common/src/test/java/org/apache/sqoop/model/TestMConnectionForms.java e2d2717
common/src/test/java/org/apache/sqoop/model/TestMConnector.java 3fde47b
common/src/test/java/org/apache/sqoop/model/TestMDriverConfig.java 9c23cc3
common/src/test/java/org/apache/sqoop/model/TestMForm.java 0bd55d9
common/src/test/java/org/apache/sqoop/model/TestMFormList.java c7ee682
common/src/test/java/org/apache/sqoop/model/TestMJob.java 96c316a
common/src/test/java/org/apache/sqoop/model/TestMJobConfig.java PRE-CREATION
common/src/test/java/org/apache/sqoop/model/TestMJobForms.java 81a8614
common/src/test/java/org/apache/sqoop/model/TestMLink.java 1be37a1
common/src/test/java/org/apache/sqoop/model/TestMLinkConfig.java PRE-CREATION
common/src/test/java/org/apache/sqoop/validation/TestValidation.java bf0ade5
common/src/test/java/org/apache/sqoop/validation/TestValidationRunner.java
647abe0
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnectorUpgrader.java
8deddb0
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/FromJobConfig.java
8b23144
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/FromJobConfiguration.java
b036421
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/LinkConfig.java
7b76eeb
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/LinkConfiguration.java
7d614f7
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/ToJobConfig.java
a42a6ec
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/ToJobConfiguration.java
ad68681
connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/GenericJdbcExecutorTest.java
e10a5b4
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsConfigUpgrader.java
47b186c
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/FromJobConfig.java
2c98051
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/FromJobConfiguration.java
f861237
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/LinkConfig.java
b689854
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/LinkConfiguration.java
4970821
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/ToJobConfig.java
b1308db
connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/ToJobConfiguration.java
bba249c
core/src/main/java/org/apache/sqoop/connector/ConnectorHandler.java dbfdc03
core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java c87df84
core/src/main/java/org/apache/sqoop/driver/Driver.java 5297bde
core/src/main/java/org/apache/sqoop/driver/DriverConfigUpgrader.java 8d6eb78
core/src/main/java/org/apache/sqoop/driver/DriverValidator.java 9cc51dd
core/src/main/java/org/apache/sqoop/driver/JobManager.java 277c6be
core/src/main/java/org/apache/sqoop/driver/JobRequest.java 63e1e49
core/src/main/java/org/apache/sqoop/driver/configuration/DriverConfiguration.java
PRE-CREATION
core/src/main/java/org/apache/sqoop/driver/configuration/JobConfiguration.java
908a4eb
core/src/main/java/org/apache/sqoop/driver/configuration/LinkConfiguration.java
3202844
core/src/main/java/org/apache/sqoop/driver/configuration/ThrottlingConfig.java
PRE-CREATION
core/src/main/java/org/apache/sqoop/driver/configuration/ThrottlingForm.java
e73007e
core/src/main/java/org/apache/sqoop/repository/Repository.java ea1608a
core/src/main/java/org/apache/sqoop/repository/RepositoryManager.java ae7be82
core/src/main/resources/driver-config.properties 9ec5d9e
core/src/test/java/org/apache/sqoop/driver/TestDriverConfigUpgrader.java
9c39d23
core/src/test/java/org/apache/sqoop/driver/TestJobManager.java 80f45e5
core/src/test/java/org/apache/sqoop/repository/TestJdbcRepository.java
796b021
execution/mapreduce/src/main/java/org/apache/sqoop/job/io/Data.java 83c670c
execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/ConfigurationUtils.java
2ed06a8
execution/mapreduce/src/test/java/org/apache/sqoop/job/TestMapReduce.java
869c727
execution/mapreduce/src/test/java/org/apache/sqoop/job/io/TestData.java
91df426
execution/mapreduce/src/test/java/org/apache/sqoop/job/mr/TestConfigurationUtils.java
1447e00
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepoError.java
61dc3b4
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java
5dd7970
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java
58eed2d
repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java
ad42901
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java
998f5b7
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestConnectorHandling.java
8a5823d
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestDriverConfigHandling.java
567dda6
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestInputTypes.java
c4a5829
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestJobHandling.java
f22c351
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestLinkHandling.java
7378eda
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestSubmissionHandling.java
38a995f
server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java
d1b6b9a
server/src/main/java/org/apache/sqoop/handler/DriverConfigRequestHandler.java
c0d363e
server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java b61d3f5
server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java 23fc9f1
shell/src/main/java/org/apache/sqoop/shell/CloneJobFunction.java 97d8e6f
shell/src/main/java/org/apache/sqoop/shell/CloneLinkFunction.java d9babe0
shell/src/main/java/org/apache/sqoop/shell/CreateJobFunction.java ccfed31
shell/src/main/java/org/apache/sqoop/shell/CreateLinkFunction.java 33d60c8
shell/src/main/java/org/apache/sqoop/shell/ShowConnectorFunction.java 2ba75b4
shell/src/main/java/org/apache/sqoop/shell/ShowDriverConfigFunction.java
e6e1004
shell/src/main/java/org/apache/sqoop/shell/ShowJobFunction.java e3f1f47
shell/src/main/java/org/apache/sqoop/shell/ShowLinkFunction.java f500b9e
shell/src/main/java/org/apache/sqoop/shell/SqoopFunction.java 5d69c2a
shell/src/main/java/org/apache/sqoop/shell/UpdateJobFunction.java 96d1fd8
shell/src/main/java/org/apache/sqoop/shell/UpdateLinkFunction.java 30bb63e
shell/src/main/java/org/apache/sqoop/shell/core/Constants.java 4d3838c
shell/src/main/java/org/apache/sqoop/shell/utils/ConfigDisplayer.java
PRE-CREATION
shell/src/main/java/org/apache/sqoop/shell/utils/ConfigFiller.java
PRE-CREATION
shell/src/main/java/org/apache/sqoop/shell/utils/ConfigOptions.java
PRE-CREATION
shell/src/main/java/org/apache/sqoop/shell/utils/DynamicConfigOptions.java
PRE-CREATION
shell/src/main/java/org/apache/sqoop/shell/utils/DynamicFormOptions.java
cc63610
shell/src/main/java/org/apache/sqoop/shell/utils/FormDisplayer.java dcbccef
shell/src/main/java/org/apache/sqoop/shell/utils/FormFiller.java a0a5dc2
shell/src/main/java/org/apache/sqoop/shell/utils/FormOptions.java efd002e
shell/src/main/java/org/apache/sqoop/shell/utils/JobDynamicConfigOptions.java
PRE-CREATION
shell/src/main/java/org/apache/sqoop/shell/utils/JobDynamicFormOptions.java
87c0776
shell/src/main/java/org/apache/sqoop/shell/utils/LinkDynamicConfigOptions.java
PRE-CREATION
shell/src/main/java/org/apache/sqoop/shell/utils/LinkDynamicFormOptions.java
2952be2
spi/src/main/java/org/apache/sqoop/connector/spi/RepositoryUpgrader.java
e00b404
submission/mapreduce/src/main/java/org/apache/sqoop/submission/mapreduce/MapreduceSubmissionEngine.java
fe92ac4
test/src/main/java/org/apache/sqoop/test/testcases/ConnectorTestCase.java
6074d36
test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromHDFSToRDBMSTest.java
5e1abc1
test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/FromRDBMSToHDFSTest.java
2dc0613
test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/PartitionerTest.java
729f95e
test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/TableStagedRDBMSTest.java
562a6a6
test/src/test/java/org/apache/sqoop/integration/server/SubmissionWithDisabledModelObjectsTest.java
507ac53
Diff: https://reviews.apache.org/r/26145/diff/
Testing
-------
mvn test, pending more db testing
Thanks,
Veena Basavaraj
